LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
@ 2017-11-28 19:14 Dmitry Torokhov
  2017-11-28 19:29 ` Mika Westerberg
  2017-11-28 21:55 ` Guenter Roeck
  0 siblings, 2 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2017-11-28 19:14 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: Heikki Krogerus, Andy Shevchenko, Guenter Roeck, linux-gpio,
	linux-kernel

As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
virtual interrupt numbers for keyboard/touchpa/touchscreen controllers
in ACPI tables, they will also update BIOS version number from 1.0
to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
numbers on Strago boards to those that still carry BIOSes 1.0.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index be37946182e1..b22ea0fe86f1 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1545,6 +1545,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
+			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
 		},
 	},
 	{
@@ -1552,6 +1553,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
+			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
 		},
 	},
 	{
@@ -1559,6 +1561,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
+			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
 		},
 	},
 	{
@@ -1566,6 +1569,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
+			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
 		},
 	},
 	{}
-- 
2.15.0.417.g466bffb3ac-goog


-- 
Dmitry

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
  2017-11-28 19:14 [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0 Dmitry Torokhov
@ 2017-11-28 19:29 ` Mika Westerberg
  2017-11-28 19:46   ` Dmitry Torokhov
  2017-11-28 21:55 ` Guenter Roeck
  1 sibling, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2017-11-28 19:29 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Heikki Krogerus, Andy Shevchenko, Guenter Roeck, linux-gpio,
	linux-kernel

On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote:
> As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> virtual interrupt numbers for keyboard/touchpa/touchscreen controllers
> in ACPI tables, they will also update BIOS version number from 1.0
> to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
> numbers on Strago boards to those that still carry BIOSes 1.0.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Assuming there is no version "0.9" or so having the same issue.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
  2017-11-28 19:29 ` Mika Westerberg
@ 2017-11-28 19:46   ` Dmitry Torokhov
  2017-11-28 19:47     ` Andy Shevchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2017-11-28 19:46 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: Heikki Krogerus, Andy Shevchenko, Guenter Roeck, linux-gpio,
	linux-kernel

On Tue, Nov 28, 2017 at 09:29:47PM +0200, Mika Westerberg wrote:
> On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote:
> > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> > virtual interrupt numbers for keyboard/touchpa/touchscreen controllers
> > in ACPI tables, they will also update BIOS version number from 1.0
> > to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
> > numbers on Strago boards to those that still carry BIOSes 1.0.
> > 
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Assuming there is no version "0.9" or so having the same issue.

No, as far as I can tell they all had the default 1.0...

-- 
Dmitry

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
  2017-11-28 19:46   ` Dmitry Torokhov
@ 2017-11-28 19:47     ` Andy Shevchenko
  2018-05-22 20:44       ` Dmitry Torokhov
  0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2017-11-28 19:47 UTC (permalink / raw)
  To: Dmitry Torokhov, Mika Westerberg
  Cc: Heikki Krogerus, Guenter Roeck, linux-gpio, linux-kernel

On Tue, 2017-11-28 at 11:46 -0800, Dmitry Torokhov wrote:
> On Tue, Nov 28, 2017 at 09:29:47PM +0200, Mika Westerberg wrote:
> > On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote:
> > > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> > > virtual interrupt numbers for keyboard/touchpa/touchscreen
> > > controllers
> > > in ACPI tables, they will also update BIOS version number from 1.0
> > > to 1.1. Let's limit the DMI quirks that try to preserve virtual
> > > IRQ
> > > numbers on Strago boards to those that still carry BIOSes 1.0.
> > > 
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > 
> > Assuming there is no version "0.9" or so having the same issue.
> 
> No, as far as I can tell they all had the default 1.0...

Thanks for fixing that eventually!


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
  2017-11-28 19:14 [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0 Dmitry Torokhov
  2017-11-28 19:29 ` Mika Westerberg
@ 2017-11-28 21:55 ` Guenter Roeck
  1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2017-11-28 21:55 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Mika Westerberg, Heikki Krogerus, Andy Shevchenko, linux-gpio,
	linux-kernel

On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote:
> As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> virtual interrupt numbers for keyboard/touchpa/touchscreen controllers
> in ACPI tables, they will also update BIOS version number from 1.0
> to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
> numbers on Strago boards to those that still carry BIOSes 1.0.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index be37946182e1..b22ea0fe86f1 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -1545,6 +1545,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
>  			DMI_MATCH(DMI_PRODUCT_FAMILY, "Intel_Strago"),
> +			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
>  		},
>  	},
>  	{
> @@ -1552,6 +1553,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "HP"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Setzer"),
> +			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
>  		},
>  	},
>  	{
> @@ -1559,6 +1561,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Cyan"),
> +			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
>  		},
>  	},
>  	{
> @@ -1566,6 +1569,7 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Celes"),
> +			DMI_MATCH(DMI_BIOS_VERSION, "1.0"),
>  		},
>  	},
>  	{}
> -- 
> 2.15.0.417.g466bffb3ac-goog
> 
> 
> -- 
> Dmitry

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
  2017-11-28 19:47     ` Andy Shevchenko
@ 2018-05-22 20:44       ` Dmitry Torokhov
  0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2018-05-22 20:44 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Mika Westerberg, Heikki Krogerus, Guenter Roeck, linux-gpio,
	linux-kernel

On Tue, Nov 28, 2017 at 09:47:25PM +0200, Andy Shevchenko wrote:
> On Tue, 2017-11-28 at 11:46 -0800, Dmitry Torokhov wrote:
> > On Tue, Nov 28, 2017 at 09:29:47PM +0200, Mika Westerberg wrote:
> > > On Tue, Nov 28, 2017 at 11:14:35AM -0800, Dmitry Torokhov wrote:
> > > > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> > > > virtual interrupt numbers for keyboard/touchpa/touchscreen
> > > > controllers
> > > > in ACPI tables, they will also update BIOS version number from 1.0
> > > > to 1.1. Let's limit the DMI quirks that try to preserve virtual
> > > > IRQ
> > > > numbers on Strago boards to those that still carry BIOSes 1.0.
> > > > 
> > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > 
> > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > 
> > > Assuming there is no version "0.9" or so having the same issue.
> > 
> > No, as far as I can tell they all had the default 1.0...
> 
> Thanks for fixing that eventually!

Ugh, so this is broken, as 1.0 is BOARD version and not BIOS. Bios
version is in form of Google_BUILD.BRANCH.PATCH, so we can't really use
it to limit the workaround (as we do not have "less than" comparator).

Anyway, in coreboot we changed board version to 1.1, so we should use
it. I'll post v2. Luckily this patch has not been picked by Linus as far
as I can tell.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-05-22 20:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 19:14 [PATCH] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0 Dmitry Torokhov
2017-11-28 19:29 ` Mika Westerberg
2017-11-28 19:46   ` Dmitry Torokhov
2017-11-28 19:47     ` Andy Shevchenko
2018-05-22 20:44       ` Dmitry Torokhov
2017-11-28 21:55 ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).