LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [rcu:rcu/dev 98/99] kernel/rcu/rcutorture.c:1145:1: sparse: symbol '__pcpu_scope_rcu_torture_timer_rand' was not declared. Should it be static?
@ 2018-05-22 21:30 kbuild test robot
  2018-05-22 21:30 ` [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-05-22 21:30 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/dev
head:   477fc1978395d58ae0406293a1d963629778a39d
commit: 816e0790625af6848ef768adead22dd6302a9c41 [98/99] rcutorture: Use per-CPU random state for rcu_torture_timer()
reproduce:
        # apt-get install sparse
        git checkout 816e0790625af6848ef768adead22dd6302a9c41
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> kernel/rcu/rcutorture.c:1145:1: sparse: symbol '__pcpu_scope_rcu_torture_timer_rand' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static
  2018-05-22 21:30 [rcu:rcu/dev 98/99] kernel/rcu/rcutorture.c:1145:1: sparse: symbol '__pcpu_scope_rcu_torture_timer_rand' was not declared. Should it be static? kbuild test robot
@ 2018-05-22 21:30 ` kbuild test robot
  2018-05-22 23:21   ` Paul E. McKenney
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-05-22 21:30 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: kbuild-all, linux-kernel


Fixes: 816e0790625a ("rcutorture: Use per-CPU random state for rcu_torture_timer()")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 rcutorture.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 5683bfb..a03313e 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1142,7 +1142,7 @@ static bool rcu_torture_one_read(struct torture_random_state *trsp)
 	return true;
 }
 
-DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
+static DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
 
 /*
  * RCU torture reader from timer handler.  Dereferences rcu_torture_current,

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static
  2018-05-22 21:30 ` [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static kbuild test robot
@ 2018-05-22 23:21   ` Paul E. McKenney
  0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2018-05-22 23:21 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, linux-kernel

On Wed, May 23, 2018 at 05:30:35AM +0800, kbuild test robot wrote:
> 
> Fixes: 816e0790625a ("rcutorture: Use per-CPU random state for rcu_torture_timer()")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>

I folded this into the offending patch with attribution, thank you!

							Thanx, Paul

> ---
>  rcutorture.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 5683bfb..a03313e 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1142,7 +1142,7 @@ static bool rcu_torture_one_read(struct torture_random_state *trsp)
>  	return true;
>  }
> 
> -DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
> +static DEFINE_TORTURE_RANDOM_PERCPU(rcu_torture_timer_rand);
> 
>  /*
>   * RCU torture reader from timer handler.  Dereferences rcu_torture_current,
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-22 23:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 21:30 [rcu:rcu/dev 98/99] kernel/rcu/rcutorture.c:1145:1: sparse: symbol '__pcpu_scope_rcu_torture_timer_rand' was not declared. Should it be static? kbuild test robot
2018-05-22 21:30 ` [RFC PATCH rcu] rcutorture: __pcpu_scope_rcu_torture_timer_rand can be static kbuild test robot
2018-05-22 23:21   ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).