LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
dev@openvswitch.org, shli@kernel.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH 2/6] proc: commit to genradix
Date: Wed, 23 May 2018 18:18:45 -0400 [thread overview]
Message-ID: <20180523221845.GB23040@kmo-pixel> (raw)
In-Reply-To: <20180523112823.GA19987@bombadil.infradead.org>
On Wed, May 23, 2018 at 04:28:23AM -0700, Matthew Wilcox wrote:
> On Tue, May 22, 2018 at 09:18:17PM -0400, Kent Overstreet wrote:
> > @@ -2140,11 +2140,12 @@ proc_map_files_readdir(struct file *file, struct dir_context *ctx)
> > struct task_struct *task;
> > struct mm_struct *mm;
> > unsigned long nr_files, pos, i;
> > - struct flex_array *fa = NULL;
> > - struct map_files_info info;
> > + GENRADIX(struct map_files_info) fa;
> > struct map_files_info *p;
> > int ret;
> >
> > + genradix_init(&fa);
>
> Could we have a DEFINE_GENRADIX(type, name) which initialises the tree?
Already exists. I kind of prefer not to use it when I don't need to though, and
stick to things that look more like normal declarations instead.
next prev parent reply other threads:[~2018-05-23 22:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 1:18 [PATCH 1/6] Generic radix trees Kent Overstreet
2018-05-23 1:18 ` [PATCH 2/6] proc: commit to genradix Kent Overstreet
2018-05-23 11:28 ` Matthew Wilcox
2018-05-23 22:18 ` Kent Overstreet [this message]
2018-05-23 1:18 ` [PATCH 3/6] md: convert " Kent Overstreet
2018-05-23 1:18 ` [PATCH 4/6] openvswitch: " Kent Overstreet
2018-05-23 12:34 ` Matthew Wilcox
2018-05-23 22:24 ` Kent Overstreet
2018-05-23 1:18 ` [PATCH 5/6] selinux: " Kent Overstreet
2018-05-23 1:18 ` [PATCH 6/6] Drop flex_arrays Kent Overstreet
2018-05-23 13:39 ` Jonathan Corbet
2018-05-23 17:24 ` Dave Hansen
2018-05-23 22:06 ` Kent Overstreet
2018-05-26 3:16 ` [PATCH 1/6] Generic radix trees Liu Bo
2018-05-26 5:56 ` Kent Overstreet
2018-05-29 1:48 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523221845.GB23040@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dev@openvswitch.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
--cc=shli@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--subject='Re: [PATCH 2/6] proc: commit to genradix' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).