LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, Guenter Roeck <groeck@chromium.org>,
	"Patel, Chintan M" <chintan.m.patel@intel.com>,
	Jaroslav Kysela <perex@perex.cz>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
Date: Thu, 24 May 2018 16:11:37 +0100	[thread overview]
Message-ID: <20180524151137.GY4828@sirena.org.uk> (raw)
In-Reply-To: <CABXOdTfKXqgRecs3xuxb-XRodJkK7+h5V0hqt889CsD6vkm5yA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

On Thu, May 24, 2018 at 07:55:06AM -0700, Guenter Roeck wrote:
> On Thu, May 24, 2018 at 7:18 AM Mark Brown <broonie@kernel.org> wrote:

Your mail client formatting seems to be broken, the word wrapping is
really funky (it looks like it's breaking longer than 80 column lines in
the middle of paragraphs rather than flowing paragraphs within 80
columns).

> > > I don't mind adding the structures to
> > > sound/soc/intel/skylake/skl-tplg-interface.h,
> > > but it seems a bit out of scope to tie this with moving the file to
> > > include/uapi/sound.
> > > I think that should be a separate discussion.

> > Is there some reason not to just do it while we're looking at this?  I
> > don't see why we wouldn't want to do this.

> I don't mind doing this. However, keeping the change local and in a single
> patch
> would make it easier to backport, and I think that the ability to backport
> would be
> essential to get more than one-person test coverage. I also would have liked
> feedback from someone at Intel, at least for the Skylake specific
> structures.

Oh, of course - I'm just saying we should do this, not that everything
needs to be in one patch.  Obviously the code motion would be a separate
patch.

> Anyway, what file do you have in mind for the structure definitions, both
> for the ones
> in soc-tolopogy.c and the ones needed in skl-topology.c ? Everything into
> asoc.h,
> or something else ?

All of those that can appear in a firmware file, I don't super care
where they end up but possibly a separate header file or files to the
kernel specific ones as they might get used with Windows.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-05-24 15:11 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 16:58 Guenter Roeck
2018-05-22 17:14 ` Mark Brown
2018-05-22 19:59 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-23  8:24   ` Mark Brown
2018-05-23 13:42     ` Pierre-Louis Bossart
2018-05-23 13:56       ` Takashi Iwai
     [not found]         ` <CABXOdTdGyfBdZUzG-DzGgfr0Afrh9dtgdXibQreOZm7nb4z3=w@mail.gmail.com>
2018-05-23 14:58           ` Takashi Iwai
2018-05-23 15:52           ` Mark Brown
     [not found]   ` <CABXOdTd5+QJHOZ6BcSO-TfJCqcLzdd+Gbnf4HYh9i9cG+UH+1g@mail.gmail.com>
2018-05-23  9:49     ` Mark Brown
2018-05-23 13:54 ` Takashi Iwai
2018-05-23 13:56   ` Mark Brown
     [not found]     ` <CABXOdTeCr-ExO9O3XAHK-DnNf5yLGO0TPkXgs60TB90jGNB2_Q@mail.gmail.com>
2018-05-23 15:58       ` Mark Brown
2018-05-23 16:17         ` Guenter Roeck
2018-05-24  9:52           ` Takashi Iwai
2018-05-24 14:18           ` Mark Brown
2018-05-24 14:55             ` Guenter Roeck
2018-05-24 15:11               ` Mark Brown [this message]
2018-05-25  9:04                 ` [alsa-devel] " Lin, Mengdong
2018-05-25 13:20                   ` Guenter Roeck
2018-05-23 16:29   ` Guenter Roeck
2018-05-23 20:28 ` [alsa-devel] " Pierre-Louis Bossart
2018-05-23 21:22   ` Guenter Roeck
2018-05-24  3:38     ` Pierre-Louis Bossart
2018-05-25 13:40     ` Shreyas NC
2018-05-25 14:09       ` Guenter Roeck
2018-05-25 17:41         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524151137.GY4828@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=chintan.m.patel@intel.com \
    --cc=groeck@chromium.org \
    --cc=groeck@google.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --subject='Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).