LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Guenter Roeck <linux@roeck-us.net>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0
Date: Thu, 24 May 2018 09:01:54 -0700	[thread overview]
Message-ID: <20180524160154.GA177107@dtor-ws> (raw)
In-Reply-To: <CACRpkdabMV1Vy5dGjW-eRVxY9yAcVhukMY1RNnb7nbYc7keHGw@mail.gmail.com>

Hi Linus,

On Thu, May 24, 2018 at 10:19:55AM +0200, Linus Walleij wrote:
> On Tue, May 22, 2018 at 10:47 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> 
> > As Google/Intel will fix the BIOS/Coreboot issues with hardcoding
> > virtual interrupt numbers for keyboard/touchpad/touchscreen controllers
> > in ACPI tables, they will also update BOARD version number from 1.0
> > to 1.1. Let's limit the DMI quirks that try to preserve virtual IRQ
> > numbers on Strago boards to those that still carry older BIOSes.
> >
> > Note that ideally not BOARD but BIOS version should have been updated.
> > However the BIOS version used by Chrome devices has format of
> > Google_BUILD.BRANCH.PATCH which is not well suited for DMI matching as
> > we do not have "less than" match mode for DMI data.
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=197953
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >
> > v1->v2:
> >
> > - switch from matching on DMI_BIOS_VERSION to DMI_BOARD_VERSION
> 
> Patch applied for fixes.
> 
> Should this also be tagged for stable?

No, I do not think so. The workaround being active does not cause any
issues on boxes with updated firmware, so there is no point in trying to
get the patch to older kernels. It is going forward that we want the
"proper" behavior, when possible.

Also, I am not quite sure when the new firmware version will get
qualified for release.

Thanks.

-- 
Dmitry

      reply	other threads:[~2018-05-24 16:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 20:47 Dmitry Torokhov
2018-05-23  4:36 ` Mika Westerberg
2018-05-23  4:46 ` Guenter Roeck
2018-05-23  8:54 ` Andy Shevchenko
2018-05-24  8:19 ` Linus Walleij
2018-05-24 16:01   ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524160154.GA177107@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mika.westerberg@linux.intel.com \
    --subject='Re: [PATCH v2] pinctrl: cherryview: limit Strago DMI workarounds to version 1.0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).