LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Toshi Kani <toshi.kani@hpe.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: [PATCH 0/7] Fix DM DAX handling
Date: Thu, 24 May 2018 20:55:11 -0600 [thread overview]
Message-ID: <20180525025518.11405-1-ross.zwisler@linux.intel.com> (raw)
This series fixes a few issues that I found with DM's handling of DAX
devices. Here are some of the issues I found:
* We can create a dm-stripe or dm-linear device which is made up of an
fsdax PMEM namespace and a raw PMEM namespace but which can hold a
filesystem mounted with the -o dax mount option. DAX operations to
the raw PMEM namespace part lack struct page and can fail in
interesting/unexpected ways when doing things like fork(), examining
memory with gdb, etc.
* We can create a dm-stripe or dm-linear device which is made up of an
fsdax PMEM namespace and a BRD ramdisk which can hold a filesystem
mounted with the -o dax mount option. All I/O to this filesystem
will fail.
* In DM you can't transition a dm target which could possibly support
DAX (mode DM_TYPE_DAX_BIO_BASED) to one which can't support DAX
(mode DM_TYPE_BIO_BASED), even if you never use DAX.
The first 2 patches in this series are prep work from Darrick and Dave
which improve bdev_dax_supported(). The last 5 problems fix the above
mentioned problems in DM. I feel that this series simplifies the
handling of DAX devices in DM, and the last 5 DM-related patches have a
net code reduction of 50 lines.
Darrick J. Wong (1):
fs: allow per-device dax status checking for filesystems
Dave Jiang (1):
dax: change bdev_dax_supported() to support boolean returns
Ross Zwisler (5):
dm: fix test for DAX device support
dm: prevent DAX mounts if not supported
dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode
dm-snap: remove unnecessary direct_access() stub
dm-error: remove unnecessary direct_access() stub
drivers/dax/super.c | 44 +++++++++++++++++++++----------------------
drivers/md/dm-ioctl.c | 16 ++++++----------
drivers/md/dm-snap.c | 8 --------
drivers/md/dm-table.c | 29 +++++++++++-----------------
drivers/md/dm-target.c | 7 -------
drivers/md/dm.c | 7 ++-----
fs/ext2/super.c | 3 +--
fs/ext4/super.c | 3 +--
fs/xfs/xfs_ioctl.c | 3 ++-
fs/xfs/xfs_iops.c | 30 ++++++++++++++++++++++++-----
fs/xfs/xfs_super.c | 10 ++++++++--
include/linux/dax.h | 12 ++++--------
include/linux/device-mapper.h | 8 ++++++--
13 files changed, 88 insertions(+), 92 deletions(-)
--
2.14.3
next reply other threads:[~2018-05-25 2:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 2:55 Ross Zwisler [this message]
2018-05-25 2:55 ` [PATCH 1/7] fs: allow per-device dax status checking for filesystems Ross Zwisler
2018-05-25 5:02 ` Darrick J. Wong
2018-05-25 15:42 ` Ross Zwisler
2018-05-25 19:23 ` Darrick J. Wong
2018-05-26 14:07 ` kbuild test robot
2018-05-25 2:55 ` [PATCH 2/7] dax: change bdev_dax_supported() to support boolean returns Ross Zwisler
2018-05-25 5:01 ` Darrick J. Wong
2018-05-25 2:55 ` [PATCH 3/7] dm: fix test for DAX device support Ross Zwisler
2018-05-25 2:55 ` [PATCH 4/7] dm: prevent DAX mounts if not supported Ross Zwisler
2018-05-25 19:54 ` Mike Snitzer
2018-05-25 21:36 ` Ross Zwisler
2018-05-25 2:55 ` [PATCH 5/7] dm: remove DM_TYPE_DAX_BIO_BASED dm_queue_mode Ross Zwisler
2018-05-25 2:55 ` [PATCH 6/7] dm-snap: remove unnecessary direct_access() stub Ross Zwisler
2018-05-25 2:55 ` [PATCH 7/7] dm-error: " Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525025518.11405-1-ross.zwisler@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=snitzer@redhat.com \
--cc=toshi.kani@hpe.com \
--subject='Re: [PATCH 0/7] Fix DM DAX handling' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).