LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Matthias Kaehlcke <mka@chromium.org> To: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris <briannorris@chromium.org>, Douglas Anderson <dianders@chromium.org>, Matthias Kaehlcke <mka@chromium.org> Subject: [PATCH 05/11] PM / devfreq: governors: Return device frequency limits instead of user limits Date: Fri, 25 May 2018 13:30:37 -0700 [thread overview] Message-ID: <20180525203043.249193-6-mka@chromium.org> (raw) In-Reply-To: <20180525203043.249193-1-mka@chromium.org> The performance, powersave and simpleondemand governors can return df->min/max_freq, which are the user defined frequency limits. update_devfreq() already takes care of adjusting the target frequency with the user limits if necessary, therefore we can return df->scaling_min/max_freq instead, which is the min/max frequency supported by the device at a given time (depending on the enabled/disabled OPPs) Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- drivers/devfreq/governor_performance.c | 2 +- drivers/devfreq/governor_powersave.c | 2 +- drivers/devfreq/governor_simpleondemand.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/devfreq/governor_performance.c b/drivers/devfreq/governor_performance.c index 1c990cb45098..a8e3478b3c43 100644 --- a/drivers/devfreq/governor_performance.c +++ b/drivers/devfreq/governor_performance.c @@ -20,7 +20,7 @@ static int devfreq_performance_func(struct devfreq *df, * target callback should be able to get floor value as * said in devfreq.h */ - *freq = df->max_freq; + *freq = df->scaling_max_freq; return 0; } diff --git a/drivers/devfreq/governor_powersave.c b/drivers/devfreq/governor_powersave.c index 0c42f23249ef..8696efd32e5a 100644 --- a/drivers/devfreq/governor_powersave.c +++ b/drivers/devfreq/governor_powersave.c @@ -20,7 +20,7 @@ static int devfreq_powersave_func(struct devfreq *df, * target callback should be able to get ceiling value as * said in devfreq.h */ - *freq = df->min_freq; + *freq = df->scaling_min_freq; return 0; } diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c index 3da7554b4837..805fee09c754 100644 --- a/drivers/devfreq/governor_simpleondemand.c +++ b/drivers/devfreq/governor_simpleondemand.c @@ -46,7 +46,7 @@ static int devfreq_simple_ondemand_func(struct devfreq *df, /* Assume MAX if it is going to be divided by zero */ if (stat->total_time == 0) { - *freq = df->max_freq; + *freq = df->scaling_max_freq; return 0; } @@ -59,13 +59,13 @@ static int devfreq_simple_ondemand_func(struct devfreq *df, /* Set MAX if it's busy enough */ if (stat->busy_time * 100 > stat->total_time * dfso_upthreshold) { - *freq = df->max_freq; + *freq = df->scaling_max_freq; return 0; } /* Set MAX if we do not know the initial frequency */ if (stat->current_frequency == 0) { - *freq = df->max_freq; + *freq = df->scaling_max_freq; return 0; } -- 2.17.0.921.gf22659ad46-goog
next prev parent reply other threads:[~2018-05-25 20:31 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-25 20:30 [PATCH 00/11] Add throttler driver for non-thermal throttling Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 01/11] PM / devfreq: Init user limits from OPP limits, not viceversa Matthias Kaehlcke 2018-05-28 5:26 ` Chanwoo Choi 2018-05-29 18:06 ` Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 02/11] PM / devfreq: Fix handling of min/max_freq == 0 Matthias Kaehlcke 2018-05-28 6:37 ` Chanwoo Choi 2018-05-29 18:57 ` Matthias Kaehlcke 2018-05-30 8:04 ` Chanwoo Choi 2018-05-30 21:13 ` Matthias Kaehlcke 2018-06-05 9:40 ` Chanwoo Choi 2018-05-25 20:30 ` [PATCH 03/11] PM / devfreq: Remove check for df->max_freq == 0 from governors Matthias Kaehlcke 2018-05-28 5:27 ` Chanwoo Choi 2018-05-25 20:30 ` [PATCH 04/11] PM / devfreq: Remove redundant frequency adjustment " Matthias Kaehlcke 2018-05-28 5:36 ` Chanwoo Choi 2018-05-25 20:30 ` Matthias Kaehlcke [this message] 2018-05-28 6:56 ` [PATCH 05/11] PM / devfreq: governors: Return device frequency limits instead of user limits Chanwoo Choi 2018-05-25 20:30 ` [PATCH 06/11] PM / devfreq: Add struct devfreq_policy Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 07/11] PM / devfreg: Add support policy notifiers Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 08/11] PM / devfreq: Make update_devfreq() public Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling Matthias Kaehlcke 2018-05-28 7:32 ` Chanwoo Choi 2018-05-29 20:57 ` Matthias Kaehlcke 2018-05-30 8:08 ` Chanwoo Choi 2018-05-28 8:08 ` Greg Kroah-Hartman 2018-05-29 21:30 ` Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 10/11] dt-bindings: misc: add bindings for throttler Matthias Kaehlcke 2018-05-31 16:31 ` Rob Herring 2018-05-31 18:34 ` Matthias Kaehlcke 2018-05-31 20:04 ` Rob Herring 2018-05-31 21:10 ` Matthias Kaehlcke 2018-05-25 20:30 ` [PATCH 11/11] misc/throttler: Add Chrome OS EC throttler Matthias Kaehlcke 2018-05-31 9:05 ` Enric Balletbo Serra 2018-05-31 17:33 ` Matthias Kaehlcke [not found] ` <CGME20180525203120epcas2p429d60dc21e16f0b53c58e7b1f942858f@epcms1p8> 2018-05-28 3:59 ` [PATCH 02/11] PM / devfreq: Fix handling of min/max_freq == 0 MyungJoo Ham [not found] ` <CGME20180525203122epcas3p42a494949f50aa933355840b7e46bb0fe@epcms1p2> 2018-05-28 4:51 ` [PATCH 03/11] PM / devfreq: Remove check for df->max_freq == 0 from governors MyungJoo Ham [not found] ` <CGME20180525203124epcas2p2db3f1996b33348f19a6a91cee55abb0b@epcms1p1> 2018-05-28 4:57 ` [PATCH 04/11] PM / devfreq: Remove redundant frequency adjustment " MyungJoo Ham [not found] ` <CGME20180525203125epcas3p46c7cac352ede4b0ba5d2b36bc32ad566@epcms1p8> 2018-05-28 5:04 ` [PATCH 05/11] PM / devfreq: governors: Return device frequency limits instead of user limits MyungJoo Ham 2018-05-29 19:32 ` Matthias Kaehlcke [not found] ` <CGME20180525203128epcas5p138dbf89498c03bc2a9221aa662001fd4@epcms1p3> 2018-05-28 5:19 ` [PATCH 07/11] PM / devfreg: Add support policy notifiers MyungJoo Ham 2018-05-29 20:02 ` Matthias Kaehlcke [not found] ` <CGME20180525203128epcas2p21a65a88fed7838221d02f6419f58bf26@epcms1p1> 2018-05-28 5:24 ` [PATCH 08/11] PM / devfreq: Make update_devfreq() public MyungJoo Ham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180525203043.249193-6-mka@chromium.org \ --to=mka@chromium.org \ --cc=arnd@arndb.de \ --cc=briannorris@chromium.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=gregkh@linuxfoundation.org \ --cc=kyungmin.park@samsung.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=myungjoo.ham@samsung.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).