LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Finn Thain <fthain@telegraphics.com.au>,
	Christoph Hellwig <hch@lst.de>,
	Guenter Roeck <linux@roeck-us.net>,
	Joshua Thompson <funaho@jurai.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	linux-m68k <linux-m68k@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet
Date: Tue, 29 May 2018 09:08:13 +0200	[thread overview]
Message-ID: <20180529070813.GA32615@lst.de> (raw)
In-Reply-To: <CAOmrzkKVu6vPgMgvR9JuR==Q=XmTnDf_iyXfP7sDVymaXDX20Q@mail.gmail.com>

On Tue, May 29, 2018 at 07:59:37AM +1200, Michael Schmitz wrote:
> Hi Geert,
> 
> my preference would be Finn's patch introducing a m68k
> arch_setup_pdev_archdata(). It nicely preserves what bus code sets up
> prior to registering a platform device (important for Zorro devices
> using platform or mfd devices), and allows overriding by drivers that
> need it.

Let's go with those for now.

> 
> If ever a kernel-wide consensus is reached to move this setup to the
> generic arch_setup_pdev_archdata(), we can still back out his patch at
> that time. Finn found one counterexample where absence of DMA mask
> signaled 'do not use DMA', so I think moving the DMA mask setup to
> generic code is unlikely to happen any time.

This is the right thing to do in the long run, and I'll spend some time
auditing all dma_mask users for the next merge window.

  reply	other threads:[~2018-05-29  7:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-26 23:53 Guenter Roeck
2018-05-27  3:01 ` Finn Thain
2018-05-27  4:15   ` Guenter Roeck
2018-05-28  5:33     ` Christoph Hellwig
2018-05-27  5:22   ` Michael Schmitz
2018-05-27  5:49     ` Finn Thain
2018-05-28  5:20       ` Michael Schmitz
2018-05-28  5:26         ` Finn Thain
2018-05-28 10:15           ` Geert Uytterhoeven
2018-05-28 19:59             ` Michael Schmitz
2018-05-29  7:08               ` Christoph Hellwig [this message]
2018-05-29  2:15             ` Finn Thain
2018-05-29  3:23               ` Michael Schmitz
2018-05-29  5:38                 ` Finn Thain
2018-05-29  7:11                   ` Christoph Hellwig
2018-05-29 11:59                     ` Finn Thain
2018-05-29 20:10                   ` Michael Schmitz
2018-05-29 12:04             ` Finn Thain
2018-05-30  0:28             ` Greg Ungerer
2018-05-30 19:55               ` Geert Uytterhoeven
2018-05-31  0:38                 ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529070813.GA32615@lst.de \
    --to=hch@lst.de \
    --cc=fthain@telegraphics.com.au \
    --cc=funaho@jurai.org \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=schmitzmic@gmail.com \
    --subject='Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).