LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Christoph Hellwig <firstname.lastname@example.org> To: Finn Thain <email@example.com> Cc: Michael Schmitz <firstname.lastname@example.org>, Geert Uytterhoeven <email@example.com>, Christoph Hellwig <firstname.lastname@example.org>, Guenter Roeck <email@example.com>, Joshua Thompson <firstname.lastname@example.org>, Greg Ungerer <email@example.com>, linux-m68k <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com> Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet Date: Tue, 29 May 2018 09:11:19 +0200 [thread overview] Message-ID: <20180529071119.GB32615@lst.de> (raw) In-Reply-To: <alpine.LNX.firstname.lastname@example.org> On Tue, May 29, 2018 at 03:38:23PM +1000, Finn Thain wrote: > On Tue, 29 May 2018, Michael Schmitz wrote: > > > > > > > Since an arch gets to apply limits in the dma ops it implements, why > > > would arch code also have to set a limit in the form of default > > > platform device masks? Powerpc seems to be the only arch that does > > > this. > > > > One of Christoph's recent patches removed most of arches' dma ops, > > replacing them by one generic implementation instead. m68k was one of > > the affected arches. I concede his patch series is experimental still > > and not in mainline, but may be included at some time. > > I found some patches here, > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/generic-dma-noncoherent.2 > > Looks like m68k_dma_alloc() gets renamed arch_dma_alloc() and the generic > ops don't use the dma masks. This is for the 'coherent' allocations, and literatelly nothing changes for those yet. But for the mapping path this switches m68k to use the dma-direct path, wrapped by dma-noncoherent. And these do check dev->dma_mask, although only really for sanity checking. Btw, can I get a review and testing for the above? They aren't really experimental any more, and I'd like to move architectures over as soon as possible.
next prev parent reply other threads:[~2018-05-29 7:05 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-26 23:53 [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet Guenter Roeck 2018-05-27 3:01 ` Finn Thain 2018-05-27 4:15 ` Guenter Roeck 2018-05-28 5:33 ` Christoph Hellwig 2018-05-27 5:22 ` Michael Schmitz 2018-05-27 5:49 ` Finn Thain 2018-05-28 5:20 ` Michael Schmitz 2018-05-28 5:26 ` Finn Thain 2018-05-28 10:15 ` Geert Uytterhoeven 2018-05-28 19:59 ` Michael Schmitz 2018-05-29 7:08 ` Christoph Hellwig 2018-05-29 2:15 ` Finn Thain 2018-05-29 3:23 ` Michael Schmitz 2018-05-29 5:38 ` Finn Thain 2018-05-29 7:11 ` Christoph Hellwig [this message] 2018-05-29 11:59 ` Finn Thain 2018-05-29 20:10 ` Michael Schmitz 2018-05-29 12:04 ` Finn Thain 2018-05-30 0:28 ` Greg Ungerer 2018-05-30 19:55 ` Geert Uytterhoeven 2018-05-31 0:38 ` Greg Ungerer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180529071119.GB32615@lst.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).