LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Ian Kent <raven@themaw.net>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] autofs: make autofs4 and autofs mutually exclusive
Date: Tue, 29 May 2018 11:46:46 +0200 [thread overview]
Message-ID: <20180529094702.4092022-1-arnd@arndb.de> (raw)
The autofs4 implementation is just a redirect to autofs now, but that
also means we can't have both built into the same kernel:
fs/autofs/inode.o: In function `autofs_new_ino':
inode.c:(.text+0x1b8): multiple definition of `autofs_new_ino'
fs/autofs/inode.o:inode.c:(.text+0x1b8): first defined here
fs/autofs/inode.o: In function `autofs_clean_ino':
inode.c:(.text+0x288): multiple definition of `autofs_clean_ino'
There is also a problem with trying to build both in parallel, which
leads to two 'make' processes writing to the same fs/autofs/.*.o.cmd
file, causing corruption that manifests like
fs/autofs4/../autofs/.expire.o.cmd:679: *** missing separator. Stop.
Making AUTOFS4_FS depend on AUTOFS_FS being disabled should avoid all
configurations that run into either issue.
Fixes: mmotm ("autofs: update fs/autofs4/Makefile")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/autofs4/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
index 53bc592a250d..eccf673c6c8c 100644
--- a/fs/autofs4/Kconfig
+++ b/fs/autofs4/Kconfig
@@ -1,5 +1,6 @@
config AUTOFS4_FS
tristate "Kernel automounter version 4 support (also supports v3 and v5)"
+ depends on AUTOFS_FS=n
default n
help
The automounter is a tool to automatically mount remote file systems
--
2.9.0
next reply other threads:[~2018-05-29 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 9:46 Arnd Bergmann [this message]
2018-05-30 0:48 ` Ian Kent
2018-05-30 8:41 ` Arnd Bergmann
2018-05-30 9:18 ` Ian Kent
2018-06-01 0:13 ` Andrew Morton
2018-06-01 1:35 ` Ian Kent
2018-06-01 8:42 ` Ian Kent
2018-06-01 23:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529094702.4092022-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--subject='Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).