LKML Archive on
help / color / mirror / Atom feed
From: Martin Schwidefsky <>
To: Christoph Hellwig <>
Cc: Linus Torvalds <>,
	linux-kernel <>,
	linux-s390 <>,
	Heiko Carstens <>
Subject: Re: [GIT PULL] two more s390 bug fixes for 4.17
Date: Wed, 30 May 2018 11:11:40 +0200	[thread overview]
Message-ID: <20180530111140.40c791bd@mschwideX1> (raw)
In-Reply-To: <>

On Wed, 30 May 2018 00:41:30 -0700
Christoph Hellwig <> wrote:

> > -	req->completion_data = cqr;
> > +	*((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr;
> > +  
> Please don't play such tricks.  In general your driver structure
> should have struct request embedded.  If for some reason
> struct dasd_ccw_req has a different life time please create a new
> structure instead of these hacks.

Why do you consider this to be a 'trick'? The blk_mq_rq_to_pdu is
meant to be used to access a block of data that is is associated
with a request, no? With the change we store a single value, the
pointer to a struct dasd_ccw_req. The struct request comes first,
later do_dasd_request creates the struct dasd_ccw_req with the
CCW chain for the request. And for the blk timeout handler we need
a way to find the dasd_ccw_req again.

> In either way this really doesn't look like a post-rc7 change.

You think so? It fixes a crash for s390 with a minimal number of
changed lines:

 drivers/s390/block/dasd.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

blue skies,

"Reality continues to ruin my life." - Calvin.

  reply	other threads:[~2018-05-30  9:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  5:59 Martin Schwidefsky
2018-05-30  7:41 ` Christoph Hellwig
2018-05-30  9:11   ` Martin Schwidefsky [this message]
2018-05-31 16:14     ` Christoph Hellwig
2018-06-04  8:20       ` Martin Schwidefsky
2018-05-30 12:59   ` Sebastian Ott
2018-06-08 17:40     ` Sebastian Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530111140.40c791bd@mschwideX1 \ \ \ \ \ \ \
    --subject='Re: [GIT PULL] two more s390 bug fixes for 4.17' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).