LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Rohit Khatri <rohit.khatri@mbconnectline.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event
Date: Wed, 30 May 2018 14:03:34 +0200	[thread overview]
Message-ID: <20180530120334.GA24919@kroah.com> (raw)
In-Reply-To: <c195ec31-9ea9-e728-b28b-2f093ed1f8a2@mbconnectline.com>

On Wed, May 30, 2018 at 11:36:26AM +0000, Rohit Khatri wrote:
> From: Rohit Khatri <rohit.khatri@mbconnectline.com><mailto:rohit.khatri@mbconnectline.com>
> Subject: [PATCH 4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event

What are these lines doing in the email body?

> Function kobject_uevent_env is unable to update uevent variables as sequence of code is overwriting user added environment variable(s).
> For example, if there is a variable named "KEY" in uevent environment with initial value of 0 and if update on any event using  kobject_uevent_env function, value of variable would be 0 only or whatever is initialized because after loading user called variable, function is again reloading same variables.

Please always wrap your changelog lines at the proper column, like your
editor asked you to when you wrote the patch.

> Signed-off-by: Rohit Khatri <rohit.khatri@mbconnectline.com><mailto:rohit.khatri@mbconnectline.com>
> Cc: stable@vger.kernel.org<mailto:stable@vger.kernel.org>

What is with the crazy mailto: stuff?

Please fix up and we can review the patch...

Also, does this "fix" a patch that is already in the tree?  If so,
please use the Fixes: tag to specify what commit it fixes.

thanks,

greg k-h

           reply	other threads:[~2018-05-30 12:04 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <c195ec31-9ea9-e728-b28b-2f093ed1f8a2@mbconnectline.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530120334.GA24919@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rohit.khatri@mbconnectline.com \
    --subject='Re: [PATCH v4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).