LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Re: [PATCH v4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event
       [not found] <c195ec31-9ea9-e728-b28b-2f093ed1f8a2@mbconnectline.com>
@ 2018-05-30 12:03 ` gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2018-05-30 12:03 UTC (permalink / raw)
  To: Rohit Khatri; +Cc: linux-kernel

On Wed, May 30, 2018 at 11:36:26AM +0000, Rohit Khatri wrote:
> From: Rohit Khatri <rohit.khatri@mbconnectline.com><mailto:rohit.khatri@mbconnectline.com>
> Subject: [PATCH 4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event

What are these lines doing in the email body?

> Function kobject_uevent_env is unable to update uevent variables as sequence of code is overwriting user added environment variable(s).
> For example, if there is a variable named "KEY" in uevent environment with initial value of 0 and if update on any event using  kobject_uevent_env function, value of variable would be 0 only or whatever is initialized because after loading user called variable, function is again reloading same variables.

Please always wrap your changelog lines at the proper column, like your
editor asked you to when you wrote the patch.

> Signed-off-by: Rohit Khatri <rohit.khatri@mbconnectline.com><mailto:rohit.khatri@mbconnectline.com>
> Cc: stable@vger.kernel.org<mailto:stable@vger.kernel.org>

What is with the crazy mailto: stuff?

Please fix up and we can review the patch...

Also, does this "fix" a patch that is already in the tree?  If so,
please use the Fixes: tag to specify what commit it fixes.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-05-30 12:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <c195ec31-9ea9-e728-b28b-2f093ed1f8a2@mbconnectline.com>
2018-05-30 12:03 ` [PATCH v4.17-rc7 1/1] lib/kobject_uevent : fix uevent environment variable update with kobject event gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).