LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] lib/plist.c: Export plist_*() APIs
@ 2017-12-05 14:35 Hareesh Gundu
  2017-12-05 14:41 ` Peter Zijlstra
  0 siblings, 1 reply; 6+ messages in thread
From: Hareesh Gundu @ 2017-12-05 14:35 UTC (permalink / raw)
  To: Linus Torvalds, Steven Rostedt, Mel Gorman
  Cc: efault, peterz, tglx, linux-kernel, hareeshg

Allow plist_add(), plist_del() and plist_requeue() APIs to
be referenced by kernel modules by adding the EXPORT_SYMBOL().

Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
---
 lib/plist.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/plist.c b/lib/plist.c
index 199408f..6109b75 100644
--- a/lib/plist.c
+++ b/lib/plist.c
@@ -103,6 +103,7 @@ void plist_add(struct plist_node *node, struct plist_head *head)
 
 	plist_check_head(head);
 }
+EXPORT_SYMBOL(plist_add);
 
 /**
  * plist_del - Remove a @node from plist.
@@ -132,6 +133,7 @@ void plist_del(struct plist_node *node, struct plist_head *head)
 
 	plist_check_head(head);
 }
+EXPORT_SYMBOL(plist_del);
 
 /**
  * plist_requeue - Requeue @node at end of same-prio entries.
@@ -172,6 +174,7 @@ void plist_requeue(struct plist_node *node, struct plist_head *head)
 
 	plist_check_head(head);
 }
+EXPORT_SYMBOL(plist_requeue);
 
 #ifdef CONFIG_DEBUG_PI_LIST
 #include <linux/sched.h>
-- 
1.9.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] lib/plist.c: Export plist_*() APIs
  2017-12-05 14:35 [PATCH] lib/plist.c: Export plist_*() APIs Hareesh Gundu
@ 2017-12-05 14:41 ` Peter Zijlstra
  2017-12-06 15:29   ` Hareesh Gundu
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Zijlstra @ 2017-12-05 14:41 UTC (permalink / raw)
  To: Hareesh Gundu
  Cc: Linus Torvalds, Steven Rostedt, Mel Gorman, efault, tglx, linux-kernel

On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
> Allow plist_add(), plist_del() and plist_requeue() APIs to
> be referenced by kernel modules by adding the EXPORT_SYMBOL().

No, not without also showing those modules.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] lib/plist.c: Export plist_*() APIs
  2017-12-05 14:41 ` Peter Zijlstra
@ 2017-12-06 15:29   ` Hareesh Gundu
  2017-12-06 15:59     ` Peter Zijlstra
  0 siblings, 1 reply; 6+ messages in thread
From: Hareesh Gundu @ 2017-12-06 15:29 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Linus Torvalds, Steven Rostedt, jcrouse, Mel Gorman, efault,
	tglx, linux-kernel


On 12/5/2017 8:11 PM, Peter Zijlstra wrote:
> On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
>> Allow plist_add(), plist_del() and plist_requeue() APIs to
>> be referenced by kernel modules by adding the EXPORT_SYMBOL().
This change is not for in-tree kernel module. It's for modules built 
outside of kernel tree modules.

Is it really required to show out tree kernel modules ?

> No, not without also showing those modules.
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] lib/plist.c: Export plist_*() APIs
  2017-12-06 15:29   ` Hareesh Gundu
@ 2017-12-06 15:59     ` Peter Zijlstra
  2018-05-30 12:25       ` Hareesh Gundu
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Zijlstra @ 2017-12-06 15:59 UTC (permalink / raw)
  To: Hareesh Gundu
  Cc: Linus Torvalds, Steven Rostedt, jcrouse, Mel Gorman, efault,
	tglx, linux-kernel

On Wed, Dec 06, 2017 at 08:59:27PM +0530, Hareesh Gundu wrote:
> 
> On 12/5/2017 8:11 PM, Peter Zijlstra wrote:
> > On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
> > > Allow plist_add(), plist_del() and plist_requeue() APIs to
> > > be referenced by kernel modules by adding the EXPORT_SYMBOL().
> This change is not for in-tree kernel module. It's for modules built outside
> of kernel tree modules.
> 
> Is it really required to show out tree kernel modules ?

Typically we don't add EXPORTs for functions not used in in-tree
modules.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] lib/plist.c: Export plist_*() APIs
  2017-12-06 15:59     ` Peter Zijlstra
@ 2018-05-30 12:25       ` Hareesh Gundu
  2018-05-30 14:12         ` Peter Zijlstra
  0 siblings, 1 reply; 6+ messages in thread
From: Hareesh Gundu @ 2018-05-30 12:25 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Linus Torvalds, Steven Rostedt, jcrouse, Mel Gorman, efault,
	tglx, linux-kernel



On 12/6/2017 9:29 PM, Peter Zijlstra wrote:
> On Wed, Dec 06, 2017 at 08:59:27PM +0530, Hareesh Gundu wrote:
>> On 12/5/2017 8:11 PM, Peter Zijlstra wrote:
>>> On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote:
>>>> Allow plist_add(), plist_del() and plist_requeue() APIs to
>>>> be referenced by kernel modules by adding the EXPORT_SYMBOL().
>> This change is not for in-tree kernel module. It's for modules built outside
>> of kernel tree modules.
>>
>> Is it really required to show out tree kernel modules ?
> Typically we don't add EXPORTs for functions not used in in-tree
> modules.
We changed our design and planned to have our module in-tree kernel 
instead of out tree kernel module.
Below is the reference for in-tree kernel module proposal for 
"drviers/gpu/msm" which is referring to plist_* symbols.

https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533

Could you please revisit the patch and approve for upstream.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] lib/plist.c: Export plist_*() APIs
  2018-05-30 12:25       ` Hareesh Gundu
@ 2018-05-30 14:12         ` Peter Zijlstra
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2018-05-30 14:12 UTC (permalink / raw)
  To: Hareesh Gundu
  Cc: Linus Torvalds, Steven Rostedt, jcrouse, Mel Gorman, efault,
	tglx, linux-kernel

On Wed, May 30, 2018 at 05:55:05PM +0530, Hareesh Gundu wrote:

> Below is the reference for in-tree kernel module proposal for
> "drviers/gpu/msm" which is referring to plist_* symbols.
> 
> https://source.codeaurora.org/quic/la/kernel/msm-4.9/tree/drivers/gpu/msm/adreno_dispatch.c?h=msm-4.9#n533
> 
> Could you please revisit the patch and approve for upstream.

I could not find where you actually use the priority. In any case, the
normal way is to submit the export patch along with the patches that use
it.

Please post the lot to the appropriate lists and people and go from there.

Also, you're missing all the SPDX tags, see Documentation/process/license-rules.rst

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-05-30 14:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05 14:35 [PATCH] lib/plist.c: Export plist_*() APIs Hareesh Gundu
2017-12-05 14:41 ` Peter Zijlstra
2017-12-06 15:29   ` Hareesh Gundu
2017-12-06 15:59     ` Peter Zijlstra
2018-05-30 12:25       ` Hareesh Gundu
2018-05-30 14:12         ` Peter Zijlstra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).