LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org, robh+dt@kernel.org,
	bcousson@baylibre.com, paul@pwsan.com, t-kristo@ti.com
Subject: Re: [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN
Date: Wed, 30 May 2018 08:04:02 -0700	[thread overview]
Message-ID: <20180530150402.GE5705@atomide.com> (raw)
In-Reply-To: <20180530141133.3711-6-faiz_abbas@ti.com>

* Faiz Abbas <faiz_abbas@ti.com> [180530 14:12]:
> The ti-sysc driver provides support for manipulating the idlemodes
> and interconnect level resets.
...
> --- a/arch/arm/boot/dts/dra76x.dtsi
> +++ b/arch/arm/boot/dts/dra76x.dtsi
> @@ -11,6 +11,25 @@
>  / {
>  	compatible = "ti,dra762", "ti,dra7";
>  
> +	ocp {
> +
> +		target-module@0x42c00000 {
> +			compatible = "ti,sysc-dra7-mcan";
> +			ranges = <0x0 0x42c00000 0x2000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			reg = <0x42c01900 0x4>,
> +			      <0x42c01904 0x4>,
> +			      <0x42c01908 0x4>;
> +			reg-names = "rev", "sysc", "syss";
> +			ti,sysc-mask = <(SYSC_OMAP4_SOFTRESET |
> +					 SYSC_DRA7_MCAN_ENAWAKEUP)>;
> +			ti,syss-mask = <1>;
> +			clocks = <&wkupaon_clkctrl DRA7_ADC_CLKCTRL 0>;
> +			clock-names = "fck";
> +		};
> +	};
> +
>  };

Looks good to me except I think the reset won't do anything currently
with ti-sysc.c unless you specfify also "ti,hwmods" for the module?

Can you please check? It might be worth adding the reset function to
ti-sysc.c for non "ti,hwmods" case and that just might remove the
need for any hwmod code for this module.

Regards,

Tony

  reply	other threads:[~2018-05-30 15:04 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 14:11 [PATCH v2 0/6] Add MCAN Support for dra76x Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 1/6] ARM: dra762: hwmod: Add MCAN support Faiz Abbas
2018-05-30 14:50   ` Tony Lindgren
2018-05-30 15:15     ` Tero Kristo
2018-05-30 15:28       ` Tony Lindgren
2018-05-30 15:41         ` Tero Kristo
2018-05-30 15:54           ` Tony Lindgren
2018-05-31  6:15             ` Tero Kristo
2018-05-31 15:26               ` Tony Lindgren
2018-05-31 16:35                 ` Faiz Abbas
2018-05-31 16:39                   ` Tony Lindgren
2018-05-30 14:11 ` [PATCH v2 2/6] ARM: dts: dra762: Add MCAN clock support Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 3/6] clk: ti: dra7: Add clkctrl clock data for the mcan clocks Faiz Abbas
2018-05-31  4:03   ` Rob Herring
2018-05-31 10:14     ` Faiz Abbas
2018-05-31 13:29       ` Tero Kristo
2018-06-01  6:48         ` Faiz Abbas
2018-06-01 14:26           ` Tony Lindgren
2018-06-04 13:58             ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 4/6] bus: ti-sysc: Add support for using ti-sysc for MCAN on dra76x Faiz Abbas
2018-05-30 14:57   ` Tony Lindgren
2018-05-31 10:16     ` Faiz Abbas
2018-05-31 13:50       ` Tony Lindgren
2018-05-31  4:08   ` Rob Herring
2018-05-30 14:11 ` [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN Faiz Abbas
2018-05-30 15:04   ` Tony Lindgren [this message]
2018-05-31 10:21     ` Faiz Abbas
2018-05-31 13:45       ` Tony Lindgren
2018-05-31 16:38         ` Faiz Abbas
2018-05-31  4:06   ` Rob Herring
2018-05-31 11:26     ` Faiz Abbas
2018-05-31 13:41       ` Tony Lindgren
2018-06-02  6:32   ` Stephen Boyd
2018-06-04  5:49     ` Faiz Abbas
2018-05-30 14:11 ` [PATCH v2 6/6] ARM: dts: dra76x: Add MCAN node Faiz Abbas
2018-05-30 15:07   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530150402.GE5705@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faiz_abbas@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --subject='Re: [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).