LKML Archive on
help / color / mirror / Atom feed
From: Andrew Morton <>
To: Ian Kent <>
Cc: Arnd Bergmann <>, Mark Brown <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive
Date: Thu, 31 May 2018 17:13:35 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 30 May 2018 17:18:55 +0800 Ian Kent <> wrote:

> > I actually had an alternative approach that I tried out successfully
> > but discarded as being too different from the original code. Just for
> > reference, this one would work as well, and allow both to be
> > compiled together. The version you posted is probably better.
> It's an attractive option but the problem is both implement the
> autofs file system.
> I've always thought you can't register the same file system at the
> same time from two distinct sources.
> If you're careful and compile each only as a module you could do it.
> But many configurations have autofs compiled built-in because of the
> auto-loading problems that arose back when there was an autofs fs
> module as well as an autofs fs module present in the autofs4 directory.
> Maybe it would actually work with one winning over the other but
> I'd prefer not to go that way.
> It will be gone in two subsequent releases if it gets merged and no
> changes to the retained code will be needed with this approach.

I'm losing the plot here.  Can you please confirm that this is the
patch we want?

From: Ian Kent <>
Subject: autofs: update fs/autofs4/Kconfig

Update Kconfig and add a depricated warning.

[ make autofs4 Kconfig depend on AUTOFS_FS]
Signed-off-by: Ian Kent <>
Tested-by: Randy Dunlap <>
Cc: Al Viro <>
Cc: Arnd Bergmann <>
Signed-off-by: Andrew Morton <>

 fs/autofs4/Kconfig |   42 +++++++++++++++++++++++++++++++-----------
 1 file changed, 31 insertions(+), 11 deletions(-)

diff -puN fs/autofs4/Kconfig~autofs-update-fs-autofs4-kconfig fs/autofs4/Kconfig
--- a/fs/autofs4/Kconfig~autofs-update-fs-autofs4-kconfig
+++ a/fs/autofs4/Kconfig
@@ -1,5 +1,7 @@
 config AUTOFS4_FS
-	tristate "Kernel automounter version 4 support (also supports v3)"
+	tristate "Kernel automounter version 4 support (also supports v3 and v5)"
+	default n
+	depends on AUTOFS_FS = n
 	  The automounter is a tool to automatically mount remote file systems
 	  on demand. This implementation is partially kernel-based to reduce
@@ -7,14 +9,32 @@ config AUTOFS4_FS
 	  automounter (amd), which is a pure user space daemon.
 	  To use the automounter you need the user-space tools from
-	  <>; you also
-	  want to answer Y to "NFS file system support", below.
+	  <>; you also want
+	  to answer Y to "NFS file system support", below.
-	  To compile this support as a module, choose M here: the module will be
-	  called autofs4.  You will need to add "alias autofs autofs4" to your
-	  modules configuration file.
-	  If you are not a part of a fairly large, distributed network or
-	  don't have a laptop which needs to dynamically reconfigure to the
-	  local network, you probably do not need an automounter, and can say
-	  N here.
+	  This module is in the process of being renamed from autofs4 to
+	  autofs. Since autofs is now the only module that provides the
+	  autofs file system the module is not version 4 specific.
+	  The autofs4 module is now built from the source located in
+	  fs/autofs. The autofs4 directory and its configuration entry
+	  will be removed two kernel versions from the inclusion of this
+	  change.
+	  Changes that will need to be made should be limited to:
+	  - source include statments should be changed from autofs_fs4.h to
+	    autofs_fs.h since these two header files have been merged.
+	  - user space scripts that manually load autofs4.ko should be
+	    changed to load autofs.ko. But since the module directory name
+	    and the module name are the same as the file system name there
+	    is no need to manually load module.
+	  - any "alias autofs autofs4" will need to be removed.
+	  Please configure AUTOFS_FS instead of AUTOFS4_FS from now on.
+	  NOTE: Since the modules autofs and autofs4 use the same file system
+		type name of "autofs" only one can be built. The "depends"
+		above will result in AUTOFS4_FS not appearing in .config for
+		any setting of AUTOFS_FS other than n and AUTOFS4_FS will
+		appear under the AUTOFS_FS entry otherwise which is intended
+		to draw attention to the module rename change.

  reply	other threads:[~2018-06-01  0:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  9:46 Arnd Bergmann
2018-05-30  0:48 ` Ian Kent
2018-05-30  8:41   ` Arnd Bergmann
2018-05-30  9:18     ` Ian Kent
2018-06-01  0:13       ` Andrew Morton [this message]
2018-06-01  1:35         ` Ian Kent
2018-06-01  8:42           ` Ian Kent
2018-06-01 23:12             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] autofs: make autofs4 and autofs mutually exclusive' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).