LKML Archive on
help / color / mirror / Atom feed
From: Christoph Hellwig <>
To: Ladvine D Almeida <>
Cc: Milan Broz <>,
	Alasdair Kergon <>,
	Mike Snitzer <>,
	"" <>,
	Manjunath M Bettegowda <>,
	Prabu Thangamuthu <>,
	Tejas Joglekar <>,
	device-mapper development <>,
	Joao Pinto <>
Subject: Re: [PATCH] md: dm-crypt: Add Inline Encryption support for dmcrypt
Date: Fri, 1 Jun 2018 01:16:42 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, May 30, 2018 at 02:52:07PM +0000, Ladvine D Almeida wrote:
> when the optional argument "perform_inline_encrypt" is set, we are not unconditionally sending the bio
> to the block devices. The steps are explained below:
> 1. user invokes the dm-setup command with the registered cipher "xts" and with the optional argument
> "perform_inline_encrypt".
> 2. dm-setup invokes the setkey function of the newly introduced algorithm, which finds the available key slots
> to be programmed(UFS Host controller Inline Encryption engine has multiple keyslots), program the key slot,
> and return the key slot index as return value of the set key function.
> 3. When read/write operation happens, crypt_map() function in dm-crypt validates whether there is associated
> key configuration index for the request. The Bio will be submitted directly in this case only with the associated
> crypto context.
> 4. Block device driver, eg. UFS host controller driver will create the Transfer requests as per this crypto context and
> encryption happens inside the controller.

Why isn't this all controlled by the ufs drivers, using helpers as

Also why do we even need this API over just implementing TCG
Opal/Opalite on the device?

  parent reply	other threads:[~2018-06-01  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 13:01 Ladvine D Almeida
2018-05-28 16:32 ` Milan Broz
2018-05-30 14:52   ` Ladvine D Almeida
2018-06-01  7:52     ` Milan Broz
2018-06-01  8:16     ` Christoph Hellwig [this message]
2018-06-06 10:04       ` Ladvine D Almeida
2018-06-06 13:15         ` Christoph Hellwig
2018-06-01 14:46     ` [dm-devel] " Eric Biggers
2018-06-04 13:15       ` Ladvine D Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] md: dm-crypt: Add Inline Encryption support for dmcrypt' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).