LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Nadav Amit <namit@vmware.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, x86@kernel.org,
	Nadav Amit <namit@vmware.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v2 5/9] x86: bug: prevent gcc distortions
Date: Tue, 5 Jun 2018 15:34:55 +0800	[thread overview]
Message-ID: <201806051333.gjsWHgPs%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180604112131.59100-6-namit@vmware.com>

[-- Attachment #1: Type: text/plain, Size: 11054 bytes --]

Hi Nadav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.17 next-20180604]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nadav-Amit/x86-macrofying-inline-asm-for-better-compilation/20180605-124313
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from include/linux/bug.h:5:0,
                    from include/linux/crypto.h:23,
                    from arch/x86/kernel/asm-offsets.c:9:
   include/linux/ktime.h: In function 'ktime_divns':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
>> include/linux/ktime.h:150:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(div < 0);
     ^~~~~~
   include/linux/rhashtable.h: In function 'rhashtable_lookup_insert_fast':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
>> include/linux/rhashtable.h:936:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(ht->p.obj_hashfn);
     ^~~~~~
   include/linux/rhashtable.h: In function 'rhashtable_lookup_get_insert_fast':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
   include/linux/rhashtable.h:962:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(ht->p.obj_hashfn);
     ^~~~~~
   include/linux/rhashtable.h: In function 'rhashtable_lookup_insert_key':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
   include/linux/rhashtable.h:996:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(!ht->p.obj_hashfn || !key);
     ^~~~~~
   include/linux/rhashtable.h: In function 'rhashtable_lookup_get_insert_key':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
   include/linux/rhashtable.h:1020:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(!ht->p.obj_hashfn || !key);
     ^~~~~~
   include/linux/crypto.h: In function 'crypto_blkcipher_cast':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
>> include/linux/crypto.h:1118:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(crypto_tfm_alg_type(tfm) != CRYPTO_ALG_TYPE_BLKCIPHER);
     ^~~~~~
   include/linux/crypto.h: In function 'crypto_cipher_cast':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
   include/linux/crypto.h:1438:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(crypto_tfm_alg_type(tfm) != CRYPTO_ALG_TYPE_CIPHER);
     ^~~~~~
   include/linux/crypto.h: In function 'crypto_comp_cast':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
   include/linux/crypto.h:1603:2: note: in expansion of macro 'BUG_ON'
     BUG_ON((crypto_tfm_alg_type(tfm) ^ CRYPTO_ALG_TYPE_COMPRESS) &
     ^~~~~~
   include/linux/quota.h: In function 'make_kqid':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
>> include/linux/quota.h:114:3: note: in expansion of macro 'BUG'
      BUG();
      ^~~
   include/linux/quota.h: In function 'make_kqid_invalid':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/linux/quota.h:141:3: note: in expansion of macro 'BUG'
      BUG();
      ^~~
   include/linux/fs.h: In function 'kill_block_super':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
>> include/linux/fs.h:2124:2: note: in expansion of macro 'BUG'
     BUG();
     ^~~
   include/linux/fs.h: In function 'break_deleg_wait':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/linux/fs.h:2371:2: note: in expansion of macro 'BUG'
     BUG();
     ^~~
   include/linux/seq_file.h: In function 'seq_get_buf':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
>> include/linux/seq_file.h:66:2: note: in expansion of macro 'BUG_ON'
     BUG_ON(m->count > m->size);
     ^~~~~~
   include/linux/seq_file.h: In function 'seq_commit':
>> arch/x86/include/asm/bug.h:31:17: error: invalid application of 'sizeof' to incomplete type 'struct bug_entry'
        "i" (sizeof(struct bug_entry)));  \
                    ^
   arch/x86/include/asm/bug.h:37:2: note: in expansion of macro '_BUG_FLAGS'
     _BUG_FLAGS(ASM_UD2, 0);     \
     ^~~~~~~~~~
   include/asm-generic/bug.h:176:47: note: in expansion of macro 'BUG'
    #define BUG_ON(condition) do { if (condition) BUG(); } while (0)
                                                  ^~~
   include/linux/seq_file.h:89:3: note: in expansion of macro 'BUG_ON'
      BUG_ON(m->count + num > m->size);
      ^~~~~~
   include/asm-generic/fixmap.h: In function 'virt_to_fix':

vim +31 arch/x86/include/asm/bug.h

9a93848f arch/x86/include/asm/bug.h Peter Zijlstra  2017-02-02  24  
9a93848f arch/x86/include/asm/bug.h Peter Zijlstra  2017-02-02  25  #define _BUG_FLAGS(ins, flags)						\
68fdc55c include/asm-x86/bug.h      Thomas Gleixner 2007-10-17  26  do {									\
6eca12b3 arch/x86/include/asm/bug.h Nadav Amit      2018-06-04  27  	asm volatile("ASM_BUG ins=\"" ins "\" file=%c0 line=%c1 "	\
6eca12b3 arch/x86/include/asm/bug.h Nadav Amit      2018-06-04  28  		     "flags=%c2 size=%c3"				\
68fdc55c include/asm-x86/bug.h      Thomas Gleixner 2007-10-17  29  		     : : "i" (__FILE__), "i" (__LINE__),                \
9a93848f arch/x86/include/asm/bug.h Peter Zijlstra  2017-02-02  30  			 "i" (flags),                                   \
68fdc55c include/asm-x86/bug.h      Thomas Gleixner 2007-10-17 @31  			 "i" (sizeof(struct bug_entry)));		\
68fdc55c include/asm-x86/bug.h      Thomas Gleixner 2007-10-17  32  } while (0)
68fdc55c include/asm-x86/bug.h      Thomas Gleixner 2007-10-17  33  

:::::: The code at line 31 was first introduced by commit
:::::: 68fdc55c48fd2e8f4938a1e815216c25baf8a17e x86: unify include/asm/bug_32/64.h

:::::: TO: Thomas Gleixner <tglx@linutronix.de>
:::::: CC: Thomas Gleixner <tglx@inhelltoy.tec.linutronix.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6296 bytes --]

  reply	other threads:[~2018-06-05  7:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 11:21 [PATCH v2 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-06-04 11:21 ` [PATCH v2 1/9] Makefile: Prepare for using macros for inline asm Nadav Amit
2018-06-04 11:21 ` [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-06-04 19:04   ` Josh Poimboeuf
2018-06-05  5:41   ` kbuild test robot
2018-06-04 11:21 ` [PATCH v2 3/9] x86: refcount: prevent gcc distortions Nadav Amit
2018-06-04 22:06   ` Kees Cook
2018-06-04 22:20     ` Nadav Amit
2018-06-05  8:26   ` kbuild test robot
2018-06-04 11:21 ` [PATCH v2 4/9] x86: alternatives: macrofy locks for better inlining Nadav Amit
2018-06-05  5:36   ` kbuild test robot
2018-06-05 14:07   ` kbuild test robot
2018-06-07  3:05   ` [lkp-robot] [x86] 1a39381d70: WARNING:at_kernel/locking/mutex.c:#__mutex_unlock_slowpath kernel test robot
2018-06-04 11:21 ` [PATCH v2 5/9] x86: bug: prevent gcc distortions Nadav Amit
2018-06-05  7:34   ` kbuild test robot [this message]
2018-06-04 11:21 ` [PATCH v2 6/9] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-06-04 11:21 ` [PATCH v2 7/9] x86: extable: use macros instead of inline assembly Nadav Amit
2018-06-04 11:21 ` [PATCH v2 8/9] x86: cpufeature: " Nadav Amit
2018-06-04 11:21 ` [PATCH v2 9/9] x86: jump-labels: " Nadav Amit
2018-06-04 19:05 ` [PATCH v2 0/9] x86: macrofying inline asm for better compilation Josh Poimboeuf
2018-06-04 19:56   ` Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201806051333.gjsWHgPs%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namit@vmware.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH v2 5/9] x86: bug: prevent gcc distortions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).