LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Cc: <boris.brezillon@bootlin.com>, <richard@nod.at>,
	<wmw2@infradead.org>, <computersforpeace@gmail.com>,
	<marek.vasut@gmail.com>, <f.fainelli@gmail.com>,
	<mmayer@broadcom.com>, <rogerq@ti.com>, <ladis@linux-mips.org>,
	<ada@thorsis.com>, <honghui.zhang@mediatek.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<nagasureshkumarrelli@gmail.com>
Subject: Re: [LINUX PATCH v9 1/4] Devicetree: Add pl353 smc controller devicetree binding information
Date: Thu, 7 Jun 2018 17:42:03 +0200	[thread overview]
Message-ID: <20180607174203.035f187d@xps13> (raw)
In-Reply-To: <1528271382-21690-2-git-send-email-naga.sureshkumar.relli@xilinx.com>

Hi Naga,

On Wed, 6 Jun 2018 13:19:39 +0530, Naga Sureshkumar Relli
<naga.sureshkumar.relli@xilinx.com> wrote:

> Add pl353 static memory controller devicetree binding information.
> 
> Signed-off-by: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
> ---
> Changes in v9:
>  - Addressed commens given by Randy Dunlap and Miquel Raynal

Can you please be more specific in your next changelog? I don't
remember what I suggested a few months ago :)

> Changes in v8:
>  - None
> Changes in v7:
> - Corrected clocks description
> - prefixed '#' for address and size cells 
> Changes in v6:
>  - None
> Changes in v5:
>  - Removed timing properties
> Changes in v4:
>  - none
> Changes in v3:
>  - none
> Changes in v2:
>  - modified timing binding info as per onfi timing parameters
>  - add suffix nano second as timing unit
>  - modified the clock names as per the IP spec
> ---
>  .../bindings/memory-controllers/pl353-smc.txt      | 53 ++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> new file mode 100644
> index 0000000..551e66b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt
> @@ -0,0 +1,53 @@
> +Device tree bindings for ARM PL353 static memory controller
> +
> +PL353 static memory controller supports two kinds of memory
> +interfaces.i.e NAND and SRAM/NOR interfaces.
> +The actual devices are instantiated from the child nodes of pl353 smc node.
> +
> +Required properties:
> +- compatible		: Should be "arm,pl353-smc-r2p1"

I thing Rob prefers:

- compatible: Must be one of:
  * arm, pl353-smc-r2p1

> +- reg			: Controller registers map and length.
> +- clock-names		: List of input clock names - "ref_clk", "aper_clk"
> +			  (See clock bindings for details).
> +- clocks		: Clock phandles (see clock bindings for details).
> +- address-cells		: Address cells, must be 1.
> +- size-cells		: Size cells. Must be 1.

Please avoid padding, just this is enough:

- something: And another thing.

> +
> +Child nodes:
> + For NAND the "arm,pl353-nand-r2p1" and for NOR the "cfi-flash" drivers are
> +supported as child nodes.
> +
> +Mandatory timing properties for child nodes:
> +- arm,nand-cycle-t0	: Read cycle time(t_rc).
> +- arm,nand-cycle-t1	: Write cycle time(t_wc).
> +- arm,nand-cycle-t2	: re_n assertion delay(t_rea).
> +- arm,nand-cycle-t3	: we_n de-assertion delay(t_wp).
> +- arm,nand-cycle-t4	: Status read time(t_clr)
> +- arm,nand-cycle-t5	: ID read time(t_ar)
> +- arm,nand-cycle-t6	: busy to re_n(t_rr)

I think this has nothing to do in the DT, you should handle timings
from the ->setup_data_interface() hook. If you need, you may use
different compatibles to distinguish different platform data.

> +
> +for nand partition information please refer the below file

s/nand/NAND/

> +Documentation/devicetree/bindings/mtd/partition.txt
> +
> +Example:
> +	pl353smcc_0: pl353smcc@e000e000 {

Why not something more explicit with the '-flash-controller' suffix?

> +			compatible = "arm,pl353-smc-r2p1"
> +			clock-names = "memclk", "aclk";
> +			clocks = <&clkc 11>, <&clkc 44>;
> +			reg = <0xe000e000 0x1000>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			nand_0: nand@e1000000 {
> +				compatible = "arm,pl353-nand-r2p1"

NAND chips do not have their own compatible.

> +				reg = <0xe1000000 0x1000000>;
> +				arm,nand-cycle-t0 = <0x4>;
> +				arm,nand-cycle-t1 = <0x4>;
> +				arm,nand-cycle-t2 = <0x1>;
> +				arm,nand-cycle-t3 = <0x2>;
> +				arm,nand-cycle-t4 = <0x2>;
> +				arm,nand-cycle-t5 = <0x2>;
> +				arm,nand-cycle-t6 = <0x4>;
> +				(...)
> +			};
> +	};


Thanks,
Miquèl

  reply	other threads:[~2018-06-07 15:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06  7:49 [LINUX PATCH v9 0/4] Add arm pl353 smc memory and nand driver for xilinx zynq soc Naga Sureshkumar Relli
2018-06-06  7:49 ` [LINUX PATCH v9 1/4] Devicetree: Add pl353 smc controller devicetree binding information Naga Sureshkumar Relli
2018-06-07 15:42   ` Miquel Raynal [this message]
2018-06-07 15:47     ` Miquel Raynal
2018-06-08  5:20     ` Naga Sureshkumar Relli
2018-06-08  5:51       ` Boris Brezillon
2018-06-08  8:01         ` Naga Sureshkumar Relli
2018-06-08  7:23       ` Miquel Raynal
2018-06-06  7:49 ` [LINUX PATCH v9 2/4] memory: pl353: Add driver for arm pl353 static memory controller Naga Sureshkumar Relli
2018-06-07 16:07   ` Miquel Raynal
2018-06-19 10:54     ` Naga Sureshkumar Relli
2018-06-06  7:49 ` [LINUX PATCH v9 3/4] Documentation: nand: pl353: Add documentation for controller and driver Naga Sureshkumar Relli
2018-06-06  7:49 ` [LINUX PATCH v9 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface Naga Sureshkumar Relli
2018-06-07 19:59   ` Miquel Raynal
2018-06-08 12:23     ` Naga Sureshkumar Relli
2018-06-08 12:35       ` Miquel Raynal
2018-06-08 13:08         ` Naga Sureshkumar Relli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607174203.035f187d@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=ada@thorsis.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=honghui.zhang@mediatek.com \
    --cc=ladis@linux-mips.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mmayer@broadcom.com \
    --cc=naga.sureshkumar.relli@xilinx.com \
    --cc=nagasureshkumarrelli@gmail.com \
    --cc=richard@nod.at \
    --cc=rogerq@ti.com \
    --cc=wmw2@infradead.org \
    --subject='Re: [LINUX PATCH v9 1/4] Devicetree: Add pl353 smc controller devicetree binding information' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).