LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nadav Amit <namit@vmware.com>
Cc: Xavier Deguillard <xdeguillard@vmware.com>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs
Date: Wed, 13 Jun 2018 20:21:37 +0200	[thread overview]
Message-ID: <20180613182137.GC29631@kroah.com> (raw)
In-Reply-To: <20180613110359.109033-4-namit@vmware.com>

On Wed, Jun 13, 2018 at 04:03:55AM -0700, Nadav Amit wrote:
> When balloon batching is not supported by the hypervisor, the guest
> frame number (GFN) must fit in 32-bit. However, due to a bug, this check
> was mistakenly ignored. In practice, when total RAM is greater than
> 16TB, the balloon does not work currently, making this bug unlikely to
> happen.
> 
> Fixes: ef0f8f112984 ("VMware balloon: partially inline
> vmballoon_reserve_page.")
> 

Why have a bugfix as the 3rd patch of the series?  Please put it first,
so that it can get into Linus's tree sooner.

Also, no need to line-wrap this, and drop the blank line.

And finally, does this need to go to the stable kernels?  If so, please
add the correct line for that.

thanks,

greg k-h

  reply	other threads:[~2018-06-13 18:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 11:03 [PATCH 0/7] vmw_balloon: addressing bugs and issues Nadav Amit
2018-06-13 11:03 ` [PATCH 1/7] vmw_balloon: update copyright message Nadav Amit
2018-06-13 18:20   ` Greg Kroah-Hartman
2018-06-13 18:24     ` Nadav Amit
2018-06-13 11:03 ` [PATCH 2/7] vmw_balloon: update maintainers list Nadav Amit
2018-06-13 11:03 ` [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs Nadav Amit
2018-06-13 18:21   ` Greg Kroah-Hartman [this message]
2018-06-13 18:27     ` Nadav Amit
2018-06-13 11:03 ` [PATCH 4/7] vmw_balloon: do not use 2MB without batching Nadav Amit
2018-06-13 11:03 ` [PATCH 5/7] vmw_balloon: VMCI_DOORBELL_SET does not check status Nadav Amit
2018-06-13 11:03 ` [PATCH 6/7] vmw_balloon: fix VMCI use when balloon built into kernel Nadav Amit
2018-06-13 11:03 ` [PATCH 7/7] vmw_balloon: remove inflation rate limiting Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180613182137.GC29631@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@vmware.com \
    --cc=xdeguillard@vmware.com \
    --subject='Re: [PATCH 3/7] vmw_balloon: fix inflation of 64-bit GFNs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).