From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 7E7ADC433EF for ; Wed, 13 Jun 2018 20:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EF97208CC for ; Wed, 13 Jun 2018 20:36:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EF97208CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935751AbeFMUgV (ORCPT ); Wed, 13 Jun 2018 16:36:21 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:56920 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935302AbeFMUgT (ORCPT ); Wed, 13 Jun 2018 16:36:19 -0400 Received: from ravnborg.org (unknown [158.248.196.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 57FF72003F; Wed, 13 Jun 2018 22:36:15 +0200 (CEST) Date: Wed, 13 Jun 2018 22:36:14 +0200 From: Sam Ravnborg To: Masahiro Yamada Cc: Nadav Amit , Linux Kernel Mailing List , X86 ML , Michal Marek , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kbuild mailing list Subject: Re: [PATCH v4 1/9] Makefile: Prepare for using macros for inline asm Message-ID: <20180613203614.GB10472@ravnborg.org> References: <20180612115050.185112-1-namit@vmware.com> <20180612115050.185112-2-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=ddpE2eP9Sid01c7MzoqXPA==:117 a=ddpE2eP9Sid01c7MzoqXPA==:17 a=kj9zAlcOel0A:10 a=jjLipkqUAu4O4XyU6BwA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > +macros: $(obj)/macros.s > > + @: > > If you add a phony target, it should be added to 'PHONY'. Or this part: > +archmacros: > + $(Q)$(MAKE) $(build)=arch/x86/kernel macros could be modified to specify the exact filename so this indirection is not needed. PS. Only one file posted to kbuild, so impossible to review as context is missing. Sam