LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nadav Amit <namit@vmware.com>
Cc: Xavier Deguillard <xdeguillard@vmware.com>,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 1/7] vmw_balloon: fix inflation of 64-bit GFNs
Date: Thu, 14 Jun 2018 07:23:36 +0200	[thread overview]
Message-ID: <20180614052336.GA29739@kroah.com> (raw)
In-Reply-To: <20180613135412.81660-2-namit@vmware.com>

On Wed, Jun 13, 2018 at 06:54:06AM -0700, Nadav Amit wrote:
> When balloon batching is not supported by the hypervisor, the guest
> frame number (GFN) must fit in 32-bit. However, due to a bug, this check
> was mistakenly ignored. In practice, when total RAM is greater than
> 16TB, the balloon does not work currently, making this bug unlikely to
> happen.
> 
> Fixes: ef0f8f112984 ("VMware balloon: partially inline vmballoon_reserve_page.")
> 
> Cc: stable@vger.kernel.org

Again, no blank line between these things.

Also, please break this up into two different patch series.  One for
4.18-final and one for 4.19-rc1.  You should always split up bugfixes
from new features/cleanups as that is what I have to do when sending
them to Linus.

thanks,

greg k-h

  reply	other threads:[~2018-06-14  5:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 13:54 [PATCH v2 0/7] vmw_balloon: addressing bugs and issues Nadav Amit
2018-06-13 13:54 ` [PATCH v2 1/7] vmw_balloon: fix inflation of 64-bit GFNs Nadav Amit
2018-06-14  5:23   ` Greg Kroah-Hartman [this message]
2018-06-14  5:41     ` Nadav Amit
2018-06-14  5:50       ` Greg Kroah-Hartman
2018-06-14  5:56         ` Nadav Amit
2018-06-13 13:54 ` [PATCH v2 2/7] vmw_balloon: do not use 2MB without batching Nadav Amit
2018-06-13 13:54 ` [PATCH v2 3/7] vmw_balloon: VMCI_DOORBELL_SET does not check status Nadav Amit
2018-06-13 13:54 ` [PATCH v2 4/7] vmw_balloon: fix VMCI use when balloon built into kernel Nadav Amit
2018-06-13 13:54 ` [PATCH v2 5/7] vmw_balloon: remove inflation rate limiting Nadav Amit
2018-06-13 13:54 ` [PATCH v2 6/7] vmw_balloon: update copyright message Nadav Amit
2018-06-14  5:24   ` Greg Kroah-Hartman
2018-06-14  5:33     ` Nadav Amit
2018-06-14  5:48       ` Greg Kroah-Hartman
2018-06-15 20:35       ` valdis.kletnieks
2018-06-15 20:38         ` Nadav Amit
2018-06-16  8:03           ` Greg Kroah-Hartman
2018-06-13 13:54 ` [PATCH v2 7/7] vmw_balloon: update maintainers list Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614052336.GA29739@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@vmware.com \
    --cc=stable@vger.kernel.org \
    --cc=xdeguillard@vmware.com \
    --subject='Re: [PATCH v2 1/7] vmw_balloon: fix inflation of 64-bit GFNs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).