LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nadav Amit <namit@vmware.com>
Cc: Xavier Deguillard <xdeguillard@vmware.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 6/7] vmw_balloon: update copyright message
Date: Thu, 14 Jun 2018 07:48:12 +0200	[thread overview]
Message-ID: <20180614054812.GA31336@kroah.com> (raw)
In-Reply-To: <F8F02A0A-133F-458A-9492-30C3ABD8C592@vmware.com>

On Thu, Jun 14, 2018 at 05:33:46AM +0000, Nadav Amit wrote:
> at 10:24 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, Jun 13, 2018 at 06:54:11AM -0700, Nadav Amit wrote:
> >> Removing the paragraph about writing to the Free Software Foundation's
> >> mailing address from the sample GPL notice according to checkpatch
> >> request.
> >> 
> >> In addition, updating the year and adding a license tag.
> >> 
> >> Reviewed-by: Xavier Deguillard <xdeguillard@vmware.com>
> >> Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
> >> ---
> >> drivers/misc/vmw_balloon.c | 7 ++-----
> >> 1 file changed, 2 insertions(+), 5 deletions(-)
> >> 
> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> >> index 400a1ccefc8e..b982059ce7b7 100644
> >> --- a/drivers/misc/vmw_balloon.c
> >> +++ b/drivers/misc/vmw_balloon.c
> >> @@ -1,7 +1,8 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> /*
> >>  * VMware Balloon driver.
> >>  *
> >> - * Copyright (C) 2000-2014, VMware, Inc. All Rights Reserved.
> >> + * Copyright (C) 2000-2018, VMware, Inc. All Rights Reserved.
> >>  *
> >>  * This program is free software; you can redistribute it and/or modify it
> >>  * under the terms of the GNU General Public License as published by the
> >> @@ -13,10 +14,6 @@
> >>  * NON INFRINGEMENT.  See the GNU General Public License for more
> >>  * details.
> > 
> > You still have a lot of boiler-plate text in here that can be removed.
> > Please do so.
> 
> I will remove the maintainers, since it is really unsuitable.
> 
> But what else do you want me to remove? This is a standard GPL license. If I
> am required to remove the GPL license, I will have to run checks to ensure
> it is appropriate.

Yes, all of the license text should be removed.  Right now we have 700+
differnt wordings of "This file is released under the GPL" in the kernel
tree, and we need to clean that up.  Look at all of the other SPDX
cleanups we have done already to get an idea of what is needed here.

As one example, look at 0c3b34a569f8 ("USB: typec: Remove remaining
redundant license text") which can be done after the correct SPDX line
is in the file.  That's the end-goal for all kernel files.

thanks,

greg k-h

  reply	other threads:[~2018-06-14  5:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 13:54 [PATCH v2 0/7] vmw_balloon: addressing bugs and issues Nadav Amit
2018-06-13 13:54 ` [PATCH v2 1/7] vmw_balloon: fix inflation of 64-bit GFNs Nadav Amit
2018-06-14  5:23   ` Greg Kroah-Hartman
2018-06-14  5:41     ` Nadav Amit
2018-06-14  5:50       ` Greg Kroah-Hartman
2018-06-14  5:56         ` Nadav Amit
2018-06-13 13:54 ` [PATCH v2 2/7] vmw_balloon: do not use 2MB without batching Nadav Amit
2018-06-13 13:54 ` [PATCH v2 3/7] vmw_balloon: VMCI_DOORBELL_SET does not check status Nadav Amit
2018-06-13 13:54 ` [PATCH v2 4/7] vmw_balloon: fix VMCI use when balloon built into kernel Nadav Amit
2018-06-13 13:54 ` [PATCH v2 5/7] vmw_balloon: remove inflation rate limiting Nadav Amit
2018-06-13 13:54 ` [PATCH v2 6/7] vmw_balloon: update copyright message Nadav Amit
2018-06-14  5:24   ` Greg Kroah-Hartman
2018-06-14  5:33     ` Nadav Amit
2018-06-14  5:48       ` Greg Kroah-Hartman [this message]
2018-06-15 20:35       ` valdis.kletnieks
2018-06-15 20:38         ` Nadav Amit
2018-06-16  8:03           ` Greg Kroah-Hartman
2018-06-13 13:54 ` [PATCH v2 7/7] vmw_balloon: update maintainers list Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614054812.GA31336@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@vmware.com \
    --cc=xdeguillard@vmware.com \
    --subject='Re: [PATCH v2 6/7] vmw_balloon: update copyright message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).