LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: airlied@linux.ie, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] char: agp: Change return type to vm_fault_t
Date: Mon, 2 Jul 2018 18:12:29 +0200	[thread overview]
Message-ID: <20180702161229.GC11874@kroah.com> (raw)
In-Reply-To: <CAFqt6zYKOaieNEQE3TrXLoh9uXwcWH496EyuT_Tuyf8nZ1zd=w@mail.gmail.com>

On Mon, Jul 02, 2018 at 09:33:19PM +0530, Souptick Joarder wrote:
> On Mon, Jun 18, 2018 at 5:07 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> > On Thu, May 31, 2018 at 10:38 AM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >> On Mon, May 21, 2018 at 11:47 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >>> Use new return type vm_fault_t for fault handler. For now,
> >>> this is just documenting that the function returns a
> >>> VM_FAULT value rather than an errno. Once all instances are
> >>> converted, vm_fault_t will become a distinct type.
> >>>
> >>> Ref-> commit 1c8f422059ae ("mm: change return type to
> >>> vm_fault_t") was added in 4.17-rc1 to introduce the new
> >>> typedef vm_fault_t. Currently we are making change to all
> >>> drivers to return vm_fault_t for page fault handlers. As
> >>> part of that char/agp driver is also getting changed to
> >>> return vm_fault_t type from fault handler.
> >>>
> >>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> >>> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> >>> ---
> >>>  drivers/char/agp/alpha-agp.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/char/agp/alpha-agp.c b/drivers/char/agp/alpha-agp.c
> >>> index 53fe633..c9bf2c2 100644
> >>> --- a/drivers/char/agp/alpha-agp.c
> >>> +++ b/drivers/char/agp/alpha-agp.c
> >>> @@ -11,7 +11,7 @@
> >>>
> >>>  #include "agp.h"
> >>>
> >>> -static int alpha_core_agp_vm_fault(struct vm_fault *vmf)
> >>> +static vm_fault_t alpha_core_agp_vm_fault(struct vm_fault *vmf)
> >>>  {
> >>>         alpha_agp_info *agp = agp_bridge->dev_private_data;
> >>>         dma_addr_t dma_addr;
> >>> --
> >>> 1.9.1
> >>>
> >>
> >> Any comment for this patch ?
> >
> > Any further comment on this patch ?
> 
> Greg, Can we get this patch in queue for 4.19 ?

I am not the agp maintainer, am I?  That would be David...

thanks,

greg k-h

  reply	other threads:[~2018-07-02 16:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 18:17 Souptick Joarder
2018-05-31  5:08 ` Souptick Joarder
2018-06-18 11:37   ` Souptick Joarder
2018-07-02 16:03     ` Souptick Joarder
2018-07-02 16:12       ` Greg KH [this message]
2018-07-02 16:48         ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702161229.GC11874@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH v2] char: agp: Change return type to vm_fault_t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).