LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: matthias.bgg@kernel.org, ulrich.hecht+renesas@gmail.com,
	laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com,
	p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org,
	mark.rutland@arm.com, mturquette@baylibre.com,
	sboyd@codeaurora.org, davem@davemloft.net,
	gregkh@linuxfoundation.org, mchehab@kernel.org,
	rdunlap@infradead.org, sean.wang@mediatek.com,
	linux-clk@vger.kernel.org, linux@armlinux.org.uk,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <mbrugger@suse.com>
Subject: Re: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd
Date: Tue, 3 Jul 2018 08:04:16 +0100	[thread overview]
Message-ID: <20180703070416.GD20176@dell> (raw)
In-Reply-To: <4ead47f6-2f69-2afa-bfcc-a240a9845dc4@gmail.com>

On Mon, 25 Jun 2018, Matthias Brugger wrote:

> 
> 
> On 30/04/18 12:30, Lee Jones wrote:
> > On Fri, 27 Apr 2018, matthias.bgg@kernel.org wrote:
> > 
> >> From: Matthias Brugger <mbrugger@suse.com>
> >>
> >> Add binding description for the mmsys mfd for some Mediatek
> >> devices. mmsys has some registers to control clock gates (which is
> >> used in the clk driver) and some registers to set the routing and enable
> >> the differnet blocks of the display subsystem.
> >>
> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> >> ---
> >>  .../bindings/arm/mediatek/mediatek,mmsys.txt       |  2 --
> >>  .../bindings/display/mediatek/mediatek,disp.txt    |  2 +-
> >>  .../devicetree/bindings/mfd/mediatek,mmsys.txt     | 27 ++++++++++++++++++++++
> >>  3 files changed, 28 insertions(+), 3 deletions(-)
> >>  create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> >> index 4eb8bbe15c01..4468345f8b1a 100644
> >> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> >> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt
> >> @@ -6,10 +6,8 @@ The Mediatek mmsys controller provides various clocks to the system.
> >>  Required Properties:
> >>  
> >>  - compatible: Should be one of:
> >> -	- "mediatek,mt2701-mmsys", "syscon"
> >>  	- "mediatek,mt2712-mmsys", "syscon"
> >>  	- "mediatek,mt6797-mmsys", "syscon"
> >> -	- "mediatek,mt8173-mmsys", "syscon"
> >>  - #clock-cells: Must be 1
> >>  
> >>  The mmsys controller uses the common clk binding from
> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> >> index 383183a89164..85a3b4ec06cd 100644
> >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> >> @@ -9,7 +9,7 @@ function block.
> >>  
> >>  All DISP device tree nodes must be siblings to the central MMSYS_CONFIG node.
> >>  For a description of the MMSYS_CONFIG binding, see
> >> -Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt.
> >> +Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> >>  
> >>  DISP function blocks
> >>  ====================
> >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> >> new file mode 100644
> >> index 000000000000..2331ae16917e
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt
> >> @@ -0,0 +1,27 @@
> >> +MediaTek MMSYS Multifunction Device Driver
> > 
> > What is "MMSYS"?
> > 
> > "Multi-Function Driver"s are specific to Linux.
> > 
> > What actually is the device?
> 
> It's includes all the DRM parts of the SoC together with the clocks for the
> device. MMSYS IMHO stands for Multi-Media-System.

Please update the document with that information.

Is there a datasheet I can view?

> >> +MMSYS is a multifunction device with the following sub modules:
> >> +- clocks for the multi-media subsystem
> >> +- central node for the DRM subsystem.
> >> +
> >> +This document describes the binding for MFD device. The MFD takes care to initailize
> >> +the clock driver and the DRM driver. More info see
> >> +Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> >> +
> >> +Required properties:
> >> +- compatible: Should be one of:
> >> +	- "mediatek,mt2701-mmsys", "syscon"
> >> +	- "mediatek,mt8173-mmsys", "syscon"
> >> +- #clock-cells: Must be 1
> >> +
> >> +Optional properties:
> >> +- power-domains: list of powerdomains needed for the subsystem to work
> >> +
> >> +Example:
> >> +
> >> +mmsys: clock-controller@14000000 {
> >> +	compatible = "mediatek,mt8173-mmsys", "syscon";
> >> +	reg = <0 0x14000000 0 0x1000>;
> >> +	power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> >> +	#clock-cells = <1>;
> >> +};
> > 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  parent reply	other threads:[~2018-07-03  7:04 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  9:23 [v3 00/10] arm/arm64: mediatek: Fix mmsys device probing matthias.bgg
2018-04-27  9:23 ` [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd matthias.bgg
2018-04-30 10:30   ` Lee Jones
2018-06-25 15:39     ` Matthias Brugger
2018-06-26 18:32       ` Rob Herring
2018-07-03  7:04       ` Lee Jones [this message]
2018-04-27  9:23 ` [v3 02/10] drm/mediatek: Use regmap for register access matthias.bgg
2018-04-27  9:23 ` [v3 03/10] mfd: mtk-mmsys: Add mmsys driver matthias.bgg
2018-04-30 10:18   ` Lee Jones
2018-05-24  2:52     ` Sean Wang
2018-06-25 15:33     ` Matthias Brugger
2018-07-03  7:11       ` Lee Jones
2018-07-04 16:17         ` Matthias Brugger
2018-07-04 16:45           ` Lee Jones
2018-07-05 11:25             ` Matthias Brugger
2018-07-05 12:22               ` Lee Jones
2018-07-06 13:18                 ` Matthias Brugger
2018-07-04 16:52           ` Chen-Yu Tsai
2018-04-27  9:23 ` [v3 04/10] drm/mediatek: mt2701: switch to mfd probing matthias.bgg
2018-04-30 10:42   ` CK Hu
2018-04-27  9:23 ` [v3 05/10] clk: mediatek: mt2701-mm: switch to mfd device matthias.bgg
2018-04-27  9:23 ` [v3 06/10] mfd: mtk-mmsys: Add mt8173 nodes matthias.bgg
2018-04-27  9:23 ` [v3 07/10] drm/mediatek: Add mfd support for mt8173 matthias.bgg
2018-04-27  9:24 ` [v3 08/10] clk: mediatek: mt8173-mm: switch to mfd device matthias.bgg
2018-04-27  9:24 ` [v3 09/10] drm: mediatek: Omit warning on probe defers matthias.bgg
2018-04-30 10:58   ` CK Hu
2018-04-27  9:24 ` [v3 10/10] MAINTAINERS: update Mediatek Soc entry matthias.bgg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703070416.GD20176@dell \
    --to=lee.jones@linaro.org \
    --cc=airlied@linux.ie \
    --cc=ck.hu@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=matthias.bgg@kernel.org \
    --cc=mbrugger@suse.com \
    --cc=mchehab@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=sean.wang@mediatek.com \
    --cc=ulrich.hecht+renesas@gmail.com \
    --subject='Re: [v3 01/10] dt-bindings: mediatek: mmsys: Add support for mfd' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).