LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Milian Wolff <milian.wolff@kdab.com>
Cc: Andi Kleen <andi@firstfloor.org>, Jiri Olsa <jolsa@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [RFC 00/10] perf: Add cputime events/metrics
Date: Wed, 26 Sep 2018 23:48:37 +0200 [thread overview]
Message-ID: <20180926214837.GB15357@krava> (raw)
In-Reply-To: <6856997.NognPVqETE@milian-kdab2>
On Wed, Sep 26, 2018 at 04:44:08PM +0200, Milian Wolff wrote:
> On Thursday, June 7, 2018 1:10:18 AM CEST Andi Kleen wrote:
> > > I had some issues with IDLE counter being miscounted due to stopping
> > > of the idle tick. I tried to solve it in this patch (it's part of the
> > >
> > > patchset):
> > > perf/cputime: Don't stop idle tick if there's live cputime event
> > >
> > > but I'm pretty sure it's wrong and there's better solution.
> >
> > At least on intel we already have hardware counters for different idle
> > states. You just would need to add them and convert to the same
> > unit.
> >
> > But of course it's still useful when this is not available.
> >
> > > My current plan is now to read those counters in perf top/record/report
> > > to show (at least) the idle percentage for the current profile.
> >
> > It's useful. Thanks for working on it. I was thinking about doing
> > something similar for some time.
>
> Hey Jiri,
>
> what happened to this patch series? I also believe it's super useful, even
> when it's not yet perfect.
heya,
got sidetracked.. thanks for feedback, will refresh
and repost sane version
thanks,
jirka
prev parent reply other threads:[~2018-09-26 21:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 22:15 Jiri Olsa
2018-06-06 22:15 ` [PATCH 01/10] perf tools: Uniquify the event name if there's no other matched event Jiri Olsa
2018-06-06 23:19 ` Andi Kleen
2018-06-07 6:22 ` Jiri Olsa
2018-06-07 16:09 ` Stephane Eranian
2018-06-08 0:06 ` Jiri Olsa
2018-06-06 22:15 ` [PATCH 02/10] perf tools: Fix error index for pmu event parser Jiri Olsa
2018-06-07 18:53 ` Arnaldo Carvalho de Melo
2018-06-14 6:21 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-06-06 22:15 ` [PATCH 03/10] perf stat: Add --interval-clear option Jiri Olsa
2018-06-07 18:57 ` Arnaldo Carvalho de Melo
2018-06-14 6:21 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-06-06 22:15 ` [PATCH 04/10] perf stat: Use only color_fprintf call in print_metric_only Jiri Olsa
2018-06-07 19:00 ` Arnaldo Carvalho de Melo
2018-06-14 6:22 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-06-06 22:15 ` [PATCH 05/10] perf stat: Fix metric column display Jiri Olsa
2018-06-07 19:00 ` Arnaldo Carvalho de Melo
2018-06-14 6:22 ` [tip:perf/urgent] perf stat: Fix metric column header display alignment tip-bot for Jiri Olsa
2018-06-06 22:15 ` [PATCH 06/10] perf stat: Allow to specify specific metric column len Jiri Olsa
2018-06-14 6:23 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-06-06 22:15 ` [PATCH 07/10] perf stat: Add event parsing error handling to add_default_attributes Jiri Olsa
2018-06-07 19:04 ` Arnaldo Carvalho de Melo
2018-06-07 19:05 ` Arnaldo Carvalho de Melo
2018-06-14 6:23 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-06-06 22:15 ` [PATCH 08/10] perf/cputime: Add cputime pmu Jiri Olsa
2018-06-06 22:15 ` [PATCH 09/10] perf/cputime: Don't stop idle tick if there's live cputime event Jiri Olsa
2018-06-07 15:45 ` Andi Kleen
2018-06-07 16:01 ` Stephane Eranian
2018-06-08 0:12 ` Jiri Olsa
2018-06-06 22:15 ` [PATCH 10/10] perf stat: Add cputime metric support Jiri Olsa
2018-06-06 23:10 ` [RFC 00/10] perf: Add cputime events/metrics Andi Kleen
2018-09-26 14:44 ` Milian Wolff
2018-09-26 21:48 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926214837.GB15357@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=frederic@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--subject='Re: [RFC 00/10] perf: Add cputime events/metrics' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).