LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com> To: platform-driver-x86@vger.kernel.org Cc: dvhart@infradead.org, andy@infradead.org, linux-kernel@vger.kernel.org, rajneesh.bhardwaj@intel.com, Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>, Matt Turner <matt.turner@intel.com>, Len Brown <len.brown@intel.com>, Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com> Subject: [PATCH v2 4/4] platform/x86: intel_telemetry: report debugfs failure Date: Sat, 6 Oct 2018 12:21:13 +0530 [thread overview] Message-ID: <20181006065113.669-4-rajneesh.bhardwaj@linux.intel.com> (raw) In-Reply-To: <20181006065113.669-1-rajneesh.bhardwaj@linux.intel.com> On some Goldmont based systems such as ASRock J3455M the BIOS may not enable the IPC1 device that provides access to the PMC and PUNIT. In such scenarios, the IOSS and PSS resources from the platform device can not be obtained and result in a invalid telemetry_plt_config which is an internal data structure that holds platform config and is maintained by the telemetry platform driver. This is also applicable to the platforms where the BIOS supports IPC1 device under debug configurations but IPC1 is disabled by user or the policy. This change allows user to know the reason for not seeing entries under /sys/kernel/debug/telemetry/* when there is no apparent failure at boot. Cc: Matt Turner <matt.turner@intel.com> Cc: Len Brown <len.brown@intel.com> Cc: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com> Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@intel.com> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198779 Acked-by: Matt Turner <matt.turner@intel.com> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com> --- Changes in v2: * Removed print and out label both as suggested by Andy. * changed to pr_info. * Other minor style fixes. drivers/platform/x86/intel_telemetry_debugfs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c index ffd0474b0531..1423fa8710fd 100644 --- a/drivers/platform/x86/intel_telemetry_debugfs.c +++ b/drivers/platform/x86/intel_telemetry_debugfs.c @@ -951,12 +951,16 @@ static int __init telemetry_debugfs_init(void) debugfs_conf = (struct telemetry_debugfs_conf *)id->driver_data; err = telemetry_pltconfig_valid(); - if (err < 0) + if (err < 0) { + pr_info("Invalid pltconfig, ensure IPC1 device is enabled in BIOS\n"); return -ENODEV; + } err = telemetry_debugfs_check_evts(); - if (err < 0) + if (err < 0) { + pr_info("telemetry_debugfs_check_evts failed\n"); return -EINVAL; + } register_pm_notifier(&pm_notifier); -- 2.17.1
next prev parent reply other threads:[~2018-10-06 6:54 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-06 6:51 [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info Rajneesh Bhardwaj 2018-10-06 6:51 ` [PATCH v2 2/4] platform/x86: intel_pmc_core: Fix LTR IGNORE Max offset Rajneesh Bhardwaj 2018-10-19 12:13 ` Andy Shevchenko 2018-10-06 6:51 ` [PATCH v2 3/4] platform/x86: intel_pmc_core: Decode Snoop / Non Snoop LTR Rajneesh Bhardwaj 2018-10-19 12:34 ` Andy Shevchenko 2018-10-30 7:40 ` Bhardwaj, Rajneesh 2018-10-30 9:39 ` Andy Shevchenko 2018-10-06 6:51 ` Rajneesh Bhardwaj [this message] 2018-10-19 12:39 ` [PATCH v2 4/4] platform/x86: intel_telemetry: report debugfs failure Andy Shevchenko 2018-10-30 7:41 ` Bhardwaj, Rajneesh 2018-10-30 13:12 ` Andy Shevchenko 2018-10-19 12:12 ` [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info Andy Shevchenko 2018-10-30 7:25 ` Bhardwaj, Rajneesh 2018-10-30 9:30 ` Andy Shevchenko 2018-10-30 18:03 ` Srinivas Pandruvada 2018-10-30 18:33 ` Andy Shevchenko 2018-10-30 18:50 ` Srinivas Pandruvada
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181006065113.669-4-rajneesh.bhardwaj@linux.intel.com \ --to=rajneesh.bhardwaj@linux.intel.com \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=len.brown@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=matt.turner@intel.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rajneesh.bhardwaj@intel.com \ --cc=sathyanarayanan.kuppuswamy@intel.com \ --cc=souvik.k.chakravarty@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).