LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com> To: linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH 0/5] pinctrl: simplify getting .driver_data Date: Sun, 21 Oct 2018 22:00:26 +0200 [thread overview] Message-ID: <20181021200032.1833-1-wsa+renesas@sang-engineering.com> (raw) I got tired of fixing this in Renesas drivers manually, so I took the big hammer. Remove this cumbersome code pattern which got copy-pasted too much already: - struct platform_device *pdev = to_platform_device(dev); - struct ep93xx_keypad *keypad = platform_get_drvdata(pdev); + struct ep93xx_keypad *keypad = dev_get_drvdata(dev); A branch, tested by buildbot, can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git coccinelle/get_drvdata I have been asked if it couldn't be done for dev_set_drvdata as well. I checked it and did not find one occasion where it could be simplified like this. Not much of a surprise because driver_data is usually set in probe() functions which access struct platform_device in many other ways. I am open for other comments, suggestions, too, of course. Here is the cocci-script I created: @@ struct device* d; identifier pdev; expression *ptr; @@ ( - struct platform_device *pdev = to_platform_device(d); | - struct platform_device *pdev; ... - pdev = to_platform_device(d); ) <... when != pdev - &pdev->dev + d ...> ptr = - platform_get_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - &pdev->dev + d ...> Kind regards, Wolfram Wolfram Sang (5): pinctrl: intel: pinctrl-baytrail: simplify getting .driver_data pinctrl: intel: pinctrl-cherryview: simplify getting .driver_data pinctrl: intel: pinctrl-intel: simplify getting .driver_data pinctrl: pinctrl-amd: simplify getting .driver_data pinctrl: pinctrl-at91-pio4: simplify getting .driver_data drivers/pinctrl/intel/pinctrl-baytrail.c | 6 ++---- drivers/pinctrl/intel/pinctrl-cherryview.c | 6 ++---- drivers/pinctrl/intel/pinctrl-intel.c | 6 ++---- drivers/pinctrl/pinctrl-amd.c | 6 ++---- drivers/pinctrl/pinctrl-at91-pio4.c | 6 ++---- 5 files changed, 10 insertions(+), 20 deletions(-) -- 2.19.0
next reply other threads:[~2018-10-21 20:00 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-21 20:00 Wolfram Sang [this message] 2018-10-21 20:00 ` [PATCH 1/5] pinctrl: intel: pinctrl-baytrail: simplify getting .driver_data Wolfram Sang 2018-10-21 21:19 ` Andy Shevchenko 2018-10-22 8:17 ` Mika Westerberg 2018-10-22 10:55 ` Andy Shevchenko 2018-10-30 13:22 ` Linus Walleij 2018-10-21 20:00 ` [PATCH 2/5] pinctrl: intel: pinctrl-cherryview: " Wolfram Sang 2018-10-22 8:17 ` Mika Westerberg 2018-10-21 20:00 ` [PATCH 3/5] pinctrl: intel: pinctrl-intel: " Wolfram Sang 2018-10-22 8:17 ` Mika Westerberg 2018-10-21 20:00 ` [PATCH 4/5] pinctrl: pinctrl-amd: " Wolfram Sang 2018-10-30 13:16 ` Linus Walleij 2018-10-21 20:00 ` [PATCH 5/5] pinctrl: pinctrl-at91-pio4: " Wolfram Sang 2018-10-24 11:15 ` Alexandre Belloni 2018-10-29 14:32 ` Ludovic Desroches 2018-10-30 13:24 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181021200032.1833-1-wsa+renesas@sang-engineering.com \ --to=wsa+renesas@sang-engineering.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).