LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan O'Donovan <dan@emutex.com>
Cc: linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Carlos Iglesias <carlos.iglesias@emutex.com>
Subject: Re: [PATCH v3 0/3] iio: adc128s052: add matching options
Date: Thu, 25 Oct 2018 20:49:54 +0300	[thread overview]
Message-ID: <20181025174954.GC10650@smile.fi.intel.com> (raw)
In-Reply-To: <1540481742-23596-1-git-send-email-dan@emutex.com>

On Thu, Oct 25, 2018 at 04:35:39PM +0100, Dan O'Donovan wrote:
> Hi all,
> 
> On some SKUs of AAEON's UP Squared board, there is an ADC124S101
> enumerated via ACPI. This is a pin-compatible variant of ADC124S021,
> which is already supported by the adc128s052 driver.
> 
> This patchset adds missing DT compatible strings for ADC124S021 (and
> ADC122S021) variants, adds AAEON's allocated ACPI HID, and adds the
> SPDX GPL identifier to the driver.
> 
> v2 was posted at:
> https://lore.kernel.org/lkml/20180423213805.12591-1-javier@emutex.com/

Overall LGTM
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Changes from v2:
> * Added device-tree bindings documentation for new chip variants
> * Simplified code to get ACPI match data
> * Dropped redundant patch to facilitate OF matching via ACPI _DSD
> * Added patch to replace GPL license text with SPDX identifier
> 
> Changes from v1:
> * Improved patch descriptions and series title
> * Added an initial commit introducing new compatible strings
>   (as per Jonathan's suggestion)
> * Moved of_match_ptr removal last as this patch is less important to us
> 
> Dan O'Donovan (1):
>   iio: adc128s052: use SPDX-License-Identifier
> 
> Javier Arteaga (1):
>   iio: adc128s052: Add pin-compatible IDs
> 
> Nicola Lunghi (1):
>   iio: adc128s052: add ACPI _HID AANT1280
> 
>  .../devicetree/bindings/iio/adc/ti-adc128s052.txt  |  9 ++++-
>  drivers/iio/adc/ti-adc128s052.c                    | 39 +++++++++++++++++-----
>  2 files changed, 38 insertions(+), 10 deletions(-)
> 
> -- 
> 2.7.4
> 
> 
> ------
> This email has been scanned for spam and malware by The Email Laundry.
> 

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2018-10-25 17:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 21:38 [PATCH v2 " Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 1/3] iio: adc128s052: Add pin-compatible IDs Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 2/3] iio: adc128s052: add ACPI _HID AANT1280 Javier Arteaga
2018-04-23 22:08   ` Andy Shevchenko
2018-04-24 10:51     ` Javier Arteaga
2018-04-23 21:38 ` [PATCH v2 3/3] iio: adc128s052: reuse "compatible" for ACPI _DSD Javier Arteaga
2018-10-25 15:35 ` [PATCH v3 0/3] iio: adc128s052: add matching options Dan O'Donovan
2018-10-25 15:35   ` [PATCH v3 1/3] iio: adc128s052: Add pin-compatible IDs Dan O'Donovan
2018-10-28 15:35     ` Jonathan Cameron
2018-10-30 19:37     ` Rob Herring
2018-10-25 15:35   ` [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280 Dan O'Donovan
2018-10-25 17:46     ` Andy Shevchenko
2018-10-26 10:13       ` Dan O'Donovan
2018-10-26 12:12         ` Andy Shevchenko
2018-10-27 17:14     ` Himanshu Jha
2018-10-28 11:42       ` Jonathan Cameron
2018-10-28 11:56     ` Jonathan Cameron
2018-10-25 15:35   ` [PATCH v3 3/3] iio: adc128s052: use SPDX-License-Identifier Dan O'Donovan
2018-10-28 11:58     ` Jonathan Cameron
2018-10-25 17:49   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181025174954.GC10650@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=carlos.iglesias@emutex.com \
    --cc=dan@emutex.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --subject='Re: [PATCH v3 0/3] iio: adc128s052: add matching options' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).