LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-renesas-soc@vger.kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 5/5] pinctrl: pinctrl-at91-pio4: simplify getting .driver_data
Date: Mon, 29 Oct 2018 15:32:10 +0100 [thread overview]
Message-ID: <20181029143210.m3ymirqjkhoty2wu@M43218.corp.atmel.com> (raw)
In-Reply-To: <20181021200032.1833-6-wsa+renesas@sang-engineering.com>
On Sun, Oct 21, 2018 at 10:00:31PM +0200, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Thanks
> ---
>
> Build tested only. buildbot is happy.
>
> drivers/pinctrl/pinctrl-at91-pio4.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 5a850491a5cb..4ee135d7b883 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -868,8 +868,7 @@ static struct pinctrl_desc atmel_pinctrl_desc = {
>
> static int __maybe_unused atmel_pctrl_suspend(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev);
> + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev);
> int i, j;
>
> /*
> @@ -897,8 +896,7 @@ static int __maybe_unused atmel_pctrl_suspend(struct device *dev)
>
> static int __maybe_unused atmel_pctrl_resume(struct device *dev)
> {
> - struct platform_device *pdev = to_platform_device(dev);
> - struct atmel_pioctrl *atmel_pioctrl = platform_get_drvdata(pdev);
> + struct atmel_pioctrl *atmel_pioctrl = dev_get_drvdata(dev);
> int i, j;
>
> for (i = 0; i < atmel_pioctrl->nbanks; i++) {
> --
> 2.19.0
>
next prev parent reply other threads:[~2018-10-29 14:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 20:00 [PATCH 0/5] pinctrl: simplify getting .driver_data Wolfram Sang
2018-10-21 20:00 ` [PATCH 1/5] pinctrl: intel: pinctrl-baytrail: " Wolfram Sang
2018-10-21 21:19 ` Andy Shevchenko
2018-10-22 8:17 ` Mika Westerberg
2018-10-22 10:55 ` Andy Shevchenko
2018-10-30 13:22 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 2/5] pinctrl: intel: pinctrl-cherryview: " Wolfram Sang
2018-10-22 8:17 ` Mika Westerberg
2018-10-21 20:00 ` [PATCH 3/5] pinctrl: intel: pinctrl-intel: " Wolfram Sang
2018-10-22 8:17 ` Mika Westerberg
2018-10-21 20:00 ` [PATCH 4/5] pinctrl: pinctrl-amd: " Wolfram Sang
2018-10-30 13:16 ` Linus Walleij
2018-10-21 20:00 ` [PATCH 5/5] pinctrl: pinctrl-at91-pio4: " Wolfram Sang
2018-10-24 11:15 ` Alexandre Belloni
2018-10-29 14:32 ` Ludovic Desroches [this message]
2018-10-30 13:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029143210.m3ymirqjkhoty2wu@M43218.corp.atmel.com \
--to=ludovic.desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).