LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Suganath Prabu <suganath-prabu.subramani@broadcom.com>
Cc: lukas@wunner.de, linux-scsi@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, ruscur@russell.cc,
sbobroff@linux.ibm.com, oohall@gmail.com,
andy.shevchenko@gmail.com, Sathya.Prakash@broadcom.com,
sreekanth.reddy@broadcom.com
Subject: Re: [v6 3/4] mpt3sas:Fix driver modifying persistent data.
Date: Tue, 30 Oct 2018 08:34:42 -0500 [thread overview]
Message-ID: <20181030133442.GC41022@google.com> (raw)
In-Reply-To: <1540290081-15827-4-git-send-email-suganath-prabu.subramani@broadcom.com>
On Tue, Oct 23, 2018 at 03:51:20PM +0530, Suganath Prabu wrote:
> * If EEDPTagMode field in manufacturing page11 is set,
> unset it. This is needed to fix a hardware bug
> in SAS3/SAS2 cards, So, skipping EEDPTagMode changes
> in Manufacturing page11 for SAS35 controllers.
>
> * Fix driver modifying NVRAM/persistent data in
> Manufacturing page11 along with current copy. Driver should
> change only current copy of Manufacturing page11.
These *look* like two separate changes that should be in separate patches.
Also, fix your subject line so "git log --oneline drivers/scsi/mpt3sas"
looks nice This subject line is missing a space in "mpt3sas:Fix"
Bjorn
next prev parent reply other threads:[~2018-10-30 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 10:21 [v6 0/4] mpt3sas: Hot-Plug Surprise removal support on IOC Suganath Prabu
2018-10-23 10:21 ` [v6 1/4] mpt3sas: Separate out mpt3sas_wait_for_ioc_to_operational Suganath Prabu
2018-10-30 13:22 ` Bjorn Helgaas
2018-10-23 10:21 ` [v6 2/4] mpt3sas: Fix Sync cache command failure during driver unload Suganath Prabu
2018-10-30 13:32 ` Bjorn Helgaas
2018-10-23 10:21 ` [v6 3/4] mpt3sas:Fix driver modifying persistent data Suganath Prabu
2018-10-30 13:34 ` Bjorn Helgaas [this message]
2018-10-23 10:21 ` [v6 4/4] mpt3sas: Bump driver version to 27.100.00.00 Suganath Prabu
2018-10-30 6:42 ` [v6 0/4] mpt3sas: Hot-Plug Surprise removal support on IOC Suganath Prabu Subramani
2018-10-30 13:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030133442.GC41022@google.com \
--to=helgaas@kernel.org \
--cc=Sathya.Prakash@broadcom.com \
--cc=andy.shevchenko@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
--cc=sbobroff@linux.ibm.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--subject='Re: [v6 3/4] mpt3sas:Fix driver modifying persistent data.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).