LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH V2] dt-bindings: arm: Explain capacities-dmips-mhz calculations in example
@ 2018-10-29  9:43 Viresh Kumar
  2018-10-30 22:14 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2018-10-29  9:43 UTC (permalink / raw)
  To: catalin.marinas, Rob Herring, Mark Rutland
  Cc: Viresh Kumar, linux-arm-kernel, Vincent Guittot, Daniel Lezcano,
	devicetree, linux-kernel

The example contains two values for the capacity currently, 446 in text
and 578 in code. The numbers are all correct but can confuse some of the
readers. This patch tries to explain how the numbers are calculated to
avoid same confusion going forward.

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
V1->V2:
- The numbers weren't incorrect in the example, just that it needs a
  bit more explanation for some people.

 Documentation/devicetree/bindings/arm/cpu-capacity.txt | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt b/Documentation/devicetree/bindings/arm/cpu-capacity.txt
index 9b5685a1d15d..84262cdb8d29 100644
--- a/Documentation/devicetree/bindings/arm/cpu-capacity.txt
+++ b/Documentation/devicetree/bindings/arm/cpu-capacity.txt
@@ -59,9 +59,11 @@ mhz values (normalized w.r.t. the highest value found while parsing the DT).
 ===========================================
 
 Example 1 (ARM 64-bit, 6-cpu system, two clusters):
-capacities-dmips-mhz are scaled w.r.t. 1024 (cpu@0 and cpu@1)
-supposing cluster0@max-freq=1100 and custer1@max-freq=850,
-final capacities are 1024 for cluster0 and 446 for cluster1
+The capacities-dmips-mhz or DMIPS/MHz values (scaled to 1024)
+are 1024 and 578 for cluster0 and cluster1. Further normalization
+is done by the operating system based on cluster0@max-freq=1100 and
+custer1@max-freq=850, final capacities are 1024 for cluster0 and
+446 for cluster1 (576*850/1100).
 
 cpus {
 	#address-cells = <2>;
-- 
2.19.1.568.g152ad8e3369a


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH V2] dt-bindings: arm: Explain capacities-dmips-mhz calculations in example
  2018-10-29  9:43 [PATCH V2] dt-bindings: arm: Explain capacities-dmips-mhz calculations in example Viresh Kumar
@ 2018-10-30 22:14 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2018-10-30 22:14 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: catalin.marinas, Mark Rutland, linux-arm-kernel, Vincent Guittot,
	Daniel Lezcano, devicetree, linux-kernel

On Mon, Oct 29, 2018 at 03:13:05PM +0530, Viresh Kumar wrote:
> The example contains two values for the capacity currently, 446 in text
> and 578 in code. The numbers are all correct but can confuse some of the
> readers. This patch tries to explain how the numbers are calculated to
> avoid same confusion going forward.
> 
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V1->V2:
> - The numbers weren't incorrect in the example, just that it needs a
>   bit more explanation for some people.
> 
>  Documentation/devicetree/bindings/arm/cpu-capacity.txt | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-30 22:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29  9:43 [PATCH V2] dt-bindings: arm: Explain capacities-dmips-mhz calculations in example Viresh Kumar
2018-10-30 22:14 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).