LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFC] rcu: doc: update example about stale data
@ 2018-10-28  2:16 Joel Fernandes (Google)
  2018-10-28  4:44 ` Joel Fernandes
  2018-10-28 17:21 ` Paul E. McKenney
  0 siblings, 2 replies; 7+ messages in thread
From: Joel Fernandes (Google) @ 2018-10-28  2:16 UTC (permalink / raw)
  To: linux-kernel; +Cc: Joel Fernandes (Google), Paul E. McKenney

The RCU example for 'rejecting stale data' on system-call auditting
stops iterating through the rules if a deleted one is found. It makes
more sense to continue looking at other rules once a deleted one is
rejected. Although the original example is fine, this makes it more
meaningful.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 Documentation/RCU/listRCU.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/RCU/listRCU.txt b/Documentation/RCU/listRCU.txt
index adb5a3782846..09e9a4fc723e 100644
--- a/Documentation/RCU/listRCU.txt
+++ b/Documentation/RCU/listRCU.txt
@@ -250,8 +250,7 @@ as follows:
 				spin_lock(&e->lock);
 				if (e->deleted) {
 					spin_unlock(&e->lock);
-					rcu_read_unlock();
-					return AUDIT_BUILD_CONTEXT;
+					continue;
 				}
 				rcu_read_unlock();
 				return state;
-- 
2.19.1.568.g152ad8e336-goog


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-10-31  0:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-28  2:16 [RFC] rcu: doc: update example about stale data Joel Fernandes (Google)
2018-10-28  4:44 ` Joel Fernandes
2018-10-28 17:29   ` Paul E. McKenney
2018-10-28 17:21 ` Paul E. McKenney
2018-10-29  1:16   ` Joel Fernandes
2018-10-30 23:50     ` Paul E. McKenney
2018-10-31  0:58       ` Joel Fernandes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).