LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2 0/3] tracing: a few simplifying patches
Date: Wed, 31 Oct 2018 07:45:16 -0400	[thread overview]
Message-ID: <20181031074457.103f0860@vmware.local.home> (raw)
In-Reply-To: <20181029223542.26175-1-linux@rasmusvillemoes.dk>

On Mon, 29 Oct 2018 23:35:39 +0100
Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:

Hi Rasmus,

I'm currently traveling. I'll try to take a look at these later. If you
don't hear from me by next week, feel free to send me a gentle
reminder ;-)

-- Steve


> Playing around with -Wformat-nonliteral, I stumbled on two instances
> in trace_output.c. Looking at the code a bit, turns out one can remove
> the use of the non-constant format string and eliminate some code
> duplication at the same time.
> 
> v2: Include cover letter, rename argument with_offset -> offset.
> 
> Rasmus Villemoes (3):
>   tracing: merge seq_print_sym_short() and seq_print_sym_offset()
>   tracing: avoid -Wformat-nonliteral warning
>   tracing: simplify printf'ing in seq_print_sym
> 
>  kernel/trace/trace_output.c | 38 ++++++++-----------------------------
>  1 file changed, 8 insertions(+), 30 deletions(-)
> 


      parent reply	other threads:[~2018-10-31 11:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 21:13 [PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset() Rasmus Villemoes
2018-10-26 21:13 ` [PATCH 2/3] tracing: avoid -Wformat-nonliteral warning Rasmus Villemoes
2018-10-26 21:13 ` [PATCH 3/3] tracing: simplify printf'ing in seq_print_sym Rasmus Villemoes
2018-10-26 21:41 ` [PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset() Steven Rostedt
2018-10-29 22:35 ` [PATCH v2 0/3] tracing: a few simplifying patches Rasmus Villemoes
2018-10-29 22:35   ` [PATCH v2 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset() Rasmus Villemoes
2018-10-29 22:35   ` [PATCH v2 2/3] tracing: avoid -Wformat-nonliteral warning Rasmus Villemoes
2018-10-29 22:35   ` [PATCH v2 3/3] tracing: simplify printf'ing in seq_print_sym Rasmus Villemoes
2018-10-31 11:45   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031074457.103f0860@vmware.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mingo@redhat.com \
    --subject='Re: [PATCH v2 0/3] tracing: a few simplifying patches' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).