From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C483C0044C for ; Wed, 31 Oct 2018 09:52:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF44A205F4 for ; Wed, 31 Oct 2018 09:52:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF44A205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbeJaSuA (ORCPT ); Wed, 31 Oct 2018 14:50:00 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:58982 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbeJaSuA (ORCPT ); Wed, 31 Oct 2018 14:50:00 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.23/8.16.0.23) with SMTP id w9V9n7Va025737; Wed, 31 Oct 2018 04:52:31 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from mail4.cirrus.com ([87.246.98.35]) by mx0b-001ae601.pphosted.com with ESMTP id 2ncmepcf0v-1; Wed, 31 Oct 2018 04:52:31 -0500 Received: from EX17.ad.cirrus.com (unknown [172.20.9.81]) by mail4.cirrus.com (Postfix) with ESMTP id 358DE611C8BF; Wed, 31 Oct 2018 04:55:34 -0500 (CDT) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.408.0; Wed, 31 Oct 2018 09:52:30 +0000 Received: from imbe.wolfsonmicro.main (imbe.wolfsonmicro.main [198.61.95.81]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id w9V9qU05026817; Wed, 31 Oct 2018 09:52:30 GMT Date: Wed, 31 Oct 2018 09:52:30 +0000 From: Charles Keepax To: Wolfram Sang CC: Benjamin Tissoires , Linux I2C , lkml , Subject: Re: [PATCH 2/2] i2c: Clear client->irq in i2c_device_remove Message-ID: <20181031095230.GK16508@imbe.wolfsonmicro.main> References: <20181019085958.32694-1-ckeepax@opensource.cirrus.com> <20181019085958.32694-2-ckeepax@opensource.cirrus.com> <20181028223116.GJ1882@kunai> <20181030115120.GI16508@imbe.wolfsonmicro.main> <20181030145549.GB2459@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181030145549.GB2459@kunai> User-Agent: Mutt/1.5.20 (2009-12-10) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810310083 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 30, 2018 at 02:55:50PM +0000, Wolfram Sang wrote: > > > No, that's fine. Now I get this, and I totally agree with the approach: > > > > Reviewed-by: Benjamin Tissoires > > Thanks! If one of you could provide me with a Fixes tag (for this. or > both patches?), that would be most helpful. > It's a bit of a long chain and fairly tricky to say exactly when the bug was introduced but I think this is probably the closest match: Fixes: 2fd36c552649 ("i2c: core: Map OF IRQ at probe time") I suspect the process of unbinding/rebinding would have also not worked before that commit but it would have not worked for different reasons. Thanks, Charles