LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: YU Bo <tsu.yubo@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace  printk
Date: Wed, 31 Oct 2018 09:41:10 -0400	[thread overview]
Message-ID: <20181031134109.7t3fy5p6uzj4tpa6@yubo-2> (raw)
In-Reply-To: <b12c68ec5dc34f69a3538a90a9a17e8d6b853b41.camel@perches.com>

Hi,
On Tue, Oct 30, 2018 at 08:01:50AM -0700, Joe Perches wrote:
>On Tue, 2018-10-30 at 08:01 -0400, Bo YU wrote:
>> Fix warning from checkpatch.pl use pr_* to replace printk
>
>If you look at msg, it can be unterminated with newline.
>
>> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
>[]
>> @@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>>  out:
>>  	if (r) {
>>  		devpath = kobject_get_path(kobj, GFP_KERNEL);
>> -		printk(KERN_WARNING "synth uevent: %s: %s",
>> +		pr_warn("synth uevent: %s: %s",
>>  		       devpath ?: "unknown device",
>>  		       msg ?: "failed to send uevent");
>>  		kfree(devpath);
>
>Perhaps this block should be:
>
>diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
>index 63d0816ab23b..0ba1197f366e 100644
>--- a/lib/kobject_uevent.c
>+++ b/lib/kobject_uevent.c
>@@ -195,12 +195,12 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
> 	enum kobject_action action;
> 	const char *action_args;
> 	struct kobj_uevent_env *env;
>-	const char *msg = NULL, *devpath;
>+	const char *msg = NULL;
> 	int r;
>
> 	r = kobject_action_type(buf, count, &action, &action_args);
> 	if (r) {
>-		msg = "unknown uevent action string\n";
>+		msg = "unknown uevent action string";
> 		goto out;
> 	}
>
>@@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
> 	r = kobject_action_args(action_args,
> 				count - (action_args - buf), &env);
> 	if (r == -EINVAL) {
>-		msg = "incorrect uevent action arguments\n";
>+		msg = "incorrect uevent action arguments";
> 		goto out;
> 	}
>
>@@ -223,10 +223,11 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
> 	kfree(env);
> out:
> 	if (r) {
>-		devpath = kobject_get_path(kobj, GFP_KERNEL);
>-		printk(KERN_WARNING "synth uevent: %s: %s",
>-		       devpath ?: "unknown device",
>-		       msg ?: "failed to send uevent");
>+		char *devpath devpath = kobject_get_path(kobj, GFP_KERNEL);
>+
>+		pr_warn("synth uevent: %s: %s\n",
>+			devpath ?: "unknown device",
>+			msg ?: "failed to send uevent");
> 		kfree(devpath);
> 	}
> 	return r;
Sorry, but i have two stupid questions to annoy you:
Q1: If i agree with your patch, here should i to do? Acked-by tag or others or nothing to do?
Q2: In fact, i do not know how to test the patch. Only to cat /sys/bus/pci/* or something?
Thanks,
>
>

  reply	other threads:[~2018-10-31 13:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 12:01 [PATCH 0/3] kobject: fix warnings from ehcekpatch.pl Bo YU
2018-10-30 12:01 ` [PATCH 1/3] kobject: drop unnecessary cast "%llu" for u64 Bo YU
2018-10-30 12:01 ` [PATCH 2/3] kobject: Fix warnings in lib/kobject_uevent.c Bo YU
2018-10-30 12:01 ` [PATCH 3/3] kobject: fix warnings use pr_* to replace printk Bo YU
2018-10-30 15:01   ` Joe Perches
2018-10-31 13:41     ` YU Bo [this message]
2018-10-31 16:48       ` Joe Perches
2018-11-01 11:24         ` YU Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031134109.7t3fy5p6uzj4tpa6@yubo-2 \
    --to=tsu.yubo@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --subject='Re: [PATCH 3/3] kobject: fix warnings use pr_* to replace  printk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).