LKML Archive on
help / color / mirror / Atom feed
From: "Uwe Kleine-König" <>
To: Enric Balletbo i Serra <>
	Thierry Reding <>,
	Bartlomiej Zolnierkiewicz <>,,
	Jingoo Han <>
Subject: Re: [PATCH v2] backlight: pwm_bl: Fix brightness levels for non-DT case.
Date: Tue, 6 Nov 2018 21:53:09 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Oct 30, 2018 at 11:34:41AM +0100, Enric Balletbo i Serra wrote:
> Commit '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED
> linearly to human eye")' allows the possibility to compute a default
> brightness table when there isn't the brightness-levels property in the
> DT. Unfortunately the changes made broke the pwm backlight for the
> non-DT boards.
> Usually, the non-DT boards don't pass the brightness levels via platform
> data, instead, it sets the max_brightness in their platform data and the
> driver calculates the level without a table. The ofending patch assumed


> hat when there is no brightness levels table we should create one, but this


> is clearly wrong for the non-DT case.
> After this patch the code handles the DT and the non-DT case taking in
> consideration also if max_brightness is set or not.
> Fixes: '88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED linearly to human eye")'

These ' are unusual.

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 |  |

      reply	other threads:[~2018-11-06 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30 10:34 Enric Balletbo i Serra
2018-11-06 20:53 ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] backlight: pwm_bl: Fix brightness levels for non-DT case.' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).