LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steve Capper <Steve.Capper@arm.com>
To: Anshuman Khandual <Anshuman.Khandual@arm.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Suzuki Poulose <Suzuki.Poulose@arm.com>,
	Punit Agrawal <Punit.Agrawal@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Steven Price <Steven.Price@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"mhocko@kernel.org" <mhocko@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
	"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
	nd <nd@arm.com>
Subject: Re: [PATCH V3 5/5] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages
Date: Thu, 8 Nov 2018 10:36:27 +0000	[thread overview]
Message-ID: <20181108103616.22z3imossjb5ffkw@capper-debian.cambridge.arm.com> (raw)
In-Reply-To: <1540299721-26484-6-git-send-email-anshuman.khandual@arm.com>

On Tue, Oct 23, 2018 at 06:32:01PM +0530, Anshuman Khandual wrote:
> Let arm64 subscribe to the previously added framework in which architecture
> can inform whether a given huge page size is supported for migration. This
> just overrides the default function arch_hugetlb_migration_supported() and
> enables migration for all possible HugeTLB page sizes on arm64. With this,
> HugeTLB migration support on arm64 now covers all possible HugeTLB options.
> 
>         CONT PTE    PMD    CONT PMD    PUD
>         --------    ---    --------    ---
> 4K:        64K      2M        32M      1G
> 16K:        2M     32M         1G
> 64K:        2M    512M        16G
> 
> Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>

Reviewed-by: Steve Capper <steve.capper@arm.com>

> ---
>  arch/arm64/include/asm/hugetlb.h |  5 +++++
>  arch/arm64/mm/hugetlbpage.c      | 20 ++++++++++++++++++++
>  2 files changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/hugetlb.h b/arch/arm64/include/asm/hugetlb.h
> index e73f685..656f70e 100644
> --- a/arch/arm64/include/asm/hugetlb.h
> +++ b/arch/arm64/include/asm/hugetlb.h
> @@ -20,6 +20,11 @@
>  
>  #include <asm/page.h>
>  
> +#ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
> +#define arch_hugetlb_migration_supported arch_hugetlb_migration_supported
> +extern bool arch_hugetlb_migration_supported(struct hstate *h);
> +#endif
> +
>  static inline pte_t huge_ptep_get(pte_t *ptep)
>  {
>  	return READ_ONCE(*ptep);
> diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
> index 21512ca..f3afdcf 100644
> --- a/arch/arm64/mm/hugetlbpage.c
> +++ b/arch/arm64/mm/hugetlbpage.c
> @@ -27,6 +27,26 @@
>  #include <asm/tlbflush.h>
>  #include <asm/pgalloc.h>
>  
> +#ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
> +bool arch_hugetlb_migration_supported(struct hstate *h)
> +{
> +	size_t pagesize = huge_page_size(h);
> +
> +	switch (pagesize) {
> +#ifdef CONFIG_ARM64_4K_PAGES
> +	case PUD_SIZE:
> +#endif
> +	case PMD_SIZE:
> +	case CONT_PMD_SIZE:
> +	case CONT_PTE_SIZE:
> +		return true;
> +	}
> +	pr_warn("%s: unrecognized huge page size 0x%lx\n",
> +			__func__, pagesize);
> +	return false;
> +}
> +#endif
> +
>  int pmd_huge(pmd_t pmd)
>  {
>  	return pmd_val(pmd) && !(pmd_val(pmd) & PMD_TABLE_BIT);
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-11-08 10:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 13:01 [PATCH V3 0/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-23 13:01 ` [PATCH V3 1/5] mm/hugetlb: Distinguish between migratability and movability Anshuman Khandual
2018-10-24 13:54   ` Michal Hocko
2018-11-08 10:33   ` Steve Capper
2018-10-23 13:01 ` [PATCH V3 2/5] mm/hugetlb: Enable PUD level huge page migration Anshuman Khandual
2018-11-08 10:34   ` Steve Capper
2018-10-23 13:01 ` [PATCH V3 3/5] mm/hugetlb: Enable arch specific huge page size support for migration Anshuman Khandual
2018-10-24 13:56   ` Michal Hocko
2018-10-24 13:58     ` Michal Hocko
2018-10-25  6:23       ` Anshuman Khandual
2018-10-25  7:45         ` Michal Hocko
2018-11-08 10:35   ` Steve Capper
2018-10-23 13:02 ` [PATCH V3 4/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-11-08 10:35   ` Steve Capper
2018-11-23 14:42   ` Catalin Marinas
2018-10-23 13:02 ` [PATCH V3 5/5] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages Anshuman Khandual
2018-11-08 10:36   ` Steve Capper [this message]
2018-11-23 14:42   ` Catalin Marinas
2018-11-23 15:08 ` [PATCH V3 0/5] arm64/mm: Enable HugeTLB migration Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108103616.22z3imossjb5ffkw@capper-debian.cambridge.arm.com \
    --to=steve.capper@arm.com \
    --cc=Anshuman.Khandual@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Punit.Agrawal@arm.com \
    --cc=Steven.Price@arm.com \
    --cc=Suzuki.Poulose@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mike.kravetz@oracle.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=nd@arm.com \
    --subject='Re: [PATCH V3 5/5] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).