LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	linux-iio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Vasily Khoruzhick <anarsoul@gmail.com>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	devicetree <devicetree@vger.kernel.org>,
	oskari@lemmela.net, linux-gpio@vger.kernel.org,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Quentin Schulz <quentin.schulz@bootlin.com>
Subject: Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings
Date: Sun, 11 Nov 2018 15:30:09 +0000	[thread overview]
Message-ID: <20181111152952.0375b969@archlinux> (raw)
In-Reply-To: <CAGb2v66mH5_J0K4ArFduvvQ2aE7mZxcyLORNPODj79-xhiKapQ@mail.gmail.com>

On Mon, 5 Nov 2018 13:47:50 +0800
Chen-Yu Tsai <wens@csie.org> wrote:

> On Sat, Nov 3, 2018 at 6:22 PM Jonathan Cameron
> <jic23@jic23.retrosnub.co.uk> wrote:
> >
> > On Wed, 31 Oct 2018 10:29:59 +0800
> > Chen-Yu Tsai <wens@csie.org> wrote:
> >  
> > > On Mon, Oct 29, 2018 at 9:10 PM Quentin Schulz
> > > <quentin.schulz@bootlin.com> wrote:  
> > > >
> > > > Hi Jonathan,
> > > >
> > > > On Sun, Oct 28, 2018 at 03:40:11PM +0000, Jonathan Cameron wrote:  
> > > > > On Wed, 24 Oct 2018 08:56:33 -0500
> > > > > Rob Herring <robh@kernel.org> wrote:
> > > > >  
> > > > > > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote:  
> > > > > > > The AXP803 ADC is compatible with AXP813 ADC, but add
> > > > > > > specific compatible for it.
> > > > > > >
> > > > > > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> > > > > > > ---
> > > > > > >  Documentation/devicetree/bindings/iio/adc/axp20x_adc.txt | 2 ++
> > > > > > >  1 file changed, 2 insertions(+)
> > > > > > >  
> > > > > >
> > > > > > Reviewed-by: Rob Herring <robh@kernel.org>  
> > > > >
> > > > > This doesn't seem to have any dependencies with the other patches
> > > > > so applied to the togreg branch of iio.git and pushed out as testing
> > > > > for the autobuilders to ignore.  However I am a little curious to know
> > > > > why we would add the ID and then not use it (that I can see)?
> > > > >  
> > > >
> > > > Sometimes with Allwinner (and X-Powers), two IPs seem identical until we
> > > > discover something that is slightly different. When this happens, we
> > > > have to add a compatible to differentiate both. However, we would also
> > > > need to change the Device Tree to change the compatible. We would need
> > > > to handle the driver behaviour for both Device Trees.
> > > >
> > > > So better anticipate a possible difference so that we don't have to do
> > > > some hacks in the driver to handle the device correctly.
> > > >
> > > > As always, Chen-Yu or Maxime may know better so I'm just stating what I
> > > > seem to recall.  
> > >
> > > With Allwinner stuff (X-Powers included), sometimes the documents are
> > > incomplete or have errors. We tend to add a model-specific compatible
> > > just in case things turn out not to be so compatible, unless someone
> > > has triple-checked everything, documents and actual hardware included.
> > >
> > > However we don't actually document these, so this patch isn't strictly
> > > needed. (I suppose this might annoy the device tree binding maintainers.)
> > >
> > > ChenYu  
> > I don't think it does any harm so I'll leave it in place.  Thanks for
> > the explanations.  
> 
> It might cause a bit of confusion though. We are not targetting these
> compatibles in terms of driver support, and they should not be used
> individually. IMO dropping this patch altogether is better. In the
> device tree we would use the tuplet axp803 + axp813.
> 
OK. Dropped.

Thanks,

Jonathan

> ChenYu


  reply	other threads:[~2018-11-11 15:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 18:53 [PATCH v5 00/11] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 01/11] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 02/11] dt-bindings: power: supply: axp20x: add AXP803 power bindings Oskari Lemmela
2018-10-24 13:55   ` Rob Herring
2018-10-31  2:38   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 03/11] dt-bindings: gpio: gpio-axp209: add AXP803 GPIO bindings Oskari Lemmela
2018-10-24 13:55   ` Rob Herring
2018-10-31  3:00   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings Oskari Lemmela
2018-10-24 13:56   ` Rob Herring
2018-10-28 15:40     ` Jonathan Cameron
2018-10-29 13:07       ` Quentin Schulz
2018-10-31  2:29         ` Chen-Yu Tsai
2018-11-03 10:21           ` Jonathan Cameron
2018-11-05  5:47             ` Chen-Yu Tsai
2018-11-11 15:30               ` Jonathan Cameron [this message]
2018-10-23 18:53 ` [PATCH v5 05/11] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-10-23 18:53 ` [PATCH v5 06/11] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-10-31  3:04   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 07/11] arm64: dts: allwinner: a64: sopine-baseboard: enable " Oskari Lemmela
2018-10-31  3:05   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 08/11] arm64: dts: allwinner: a64: pinebook: " Oskari Lemmela
2018-10-31  3:05   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 09/11] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-10-25 10:23   ` Lee Jones
2018-10-31  2:55   ` Chen-Yu Tsai
2018-10-23 18:53 ` [PATCH v5 10/11] mfd: axp20x: Add AC power supply cell " Oskari Lemmela
2018-10-25 10:23   ` Lee Jones
2018-10-23 18:53 ` [PATCH v5 11/11] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-10-25 10:24   ` Lee Jones
2018-10-25 13:30 ` [PATCH v5 00/11] AXP8x3 AC and battery power supply support Sebastian Reichel
2018-10-31  2:33   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181111152952.0375b969@archlinux \
    --to=jic23@jic23.retrosnub.co.uk \
    --cc=anarsoul@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=oskari@lemmela.net \
    --cc=quentin.schulz@bootlin.com \
    --cc=quentin.schulz@free-electrons.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=wens@csie.org \
    --subject='Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).