LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: iio: ad7192: Fix ad7193 channel address
@ 2019-02-20 11:08 Mircea Caprioru
2019-02-20 15:35 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Mircea Caprioru @ 2019-02-20 11:08 UTC (permalink / raw)
To: jic23
Cc: Michael.Hennerich, lars, gregkh, linux-kernel, linux-iio,
Mircea Caprioru
This patch fixes the differential channels addresses for the ad7193.
Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
---
drivers/staging/iio/adc/ad7192.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index acdbc07fd259..2fc8bc22b57b 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -109,10 +109,10 @@
#define AD7192_CH_AIN3 BIT(6) /* AIN3 - AINCOM */
#define AD7192_CH_AIN4 BIT(7) /* AIN4 - AINCOM */
-#define AD7193_CH_AIN1P_AIN2M 0x000 /* AIN1(+) - AIN2(-) */
-#define AD7193_CH_AIN3P_AIN4M 0x001 /* AIN3(+) - AIN4(-) */
-#define AD7193_CH_AIN5P_AIN6M 0x002 /* AIN5(+) - AIN6(-) */
-#define AD7193_CH_AIN7P_AIN8M 0x004 /* AIN7(+) - AIN8(-) */
+#define AD7193_CH_AIN1P_AIN2M 0x001 /* AIN1(+) - AIN2(-) */
+#define AD7193_CH_AIN3P_AIN4M 0x002 /* AIN3(+) - AIN4(-) */
+#define AD7193_CH_AIN5P_AIN6M 0x004 /* AIN5(+) - AIN6(-) */
+#define AD7193_CH_AIN7P_AIN8M 0x008 /* AIN7(+) - AIN8(-) */
#define AD7193_CH_TEMP 0x100 /* Temp senseor */
#define AD7193_CH_AIN2P_AIN2M 0x200 /* AIN2(+) - AIN2(-) */
#define AD7193_CH_AIN1 0x401 /* AIN1 - AINCOM */
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: ad7192: Fix ad7193 channel address
2019-02-20 11:08 [PATCH] staging: iio: ad7192: Fix ad7193 channel address Mircea Caprioru
@ 2019-02-20 15:35 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-02-20 15:35 UTC (permalink / raw)
To: Mircea Caprioru; +Cc: Michael.Hennerich, lars, gregkh, linux-kernel, linux-iio
On Wed, 20 Feb 2019 13:08:20 +0200
Mircea Caprioru <mircea.caprioru@analog.com> wrote:
> This patch fixes the differential channels addresses for the ad7193.
>
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
Hi
This is an impressively confusing datasheet, but I agree with the fix.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index acdbc07fd259..2fc8bc22b57b 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -109,10 +109,10 @@
> #define AD7192_CH_AIN3 BIT(6) /* AIN3 - AINCOM */
> #define AD7192_CH_AIN4 BIT(7) /* AIN4 - AINCOM */
>
> -#define AD7193_CH_AIN1P_AIN2M 0x000 /* AIN1(+) - AIN2(-) */
> -#define AD7193_CH_AIN3P_AIN4M 0x001 /* AIN3(+) - AIN4(-) */
> -#define AD7193_CH_AIN5P_AIN6M 0x002 /* AIN5(+) - AIN6(-) */
> -#define AD7193_CH_AIN7P_AIN8M 0x004 /* AIN7(+) - AIN8(-) */
> +#define AD7193_CH_AIN1P_AIN2M 0x001 /* AIN1(+) - AIN2(-) */
> +#define AD7193_CH_AIN3P_AIN4M 0x002 /* AIN3(+) - AIN4(-) */
> +#define AD7193_CH_AIN5P_AIN6M 0x004 /* AIN5(+) - AIN6(-) */
> +#define AD7193_CH_AIN7P_AIN8M 0x008 /* AIN7(+) - AIN8(-) */
> #define AD7193_CH_TEMP 0x100 /* Temp senseor */
> #define AD7193_CH_AIN2P_AIN2M 0x200 /* AIN2(+) - AIN2(-) */
> #define AD7193_CH_AIN1 0x401 /* AIN1 - AINCOM */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 11:08 [PATCH] staging: iio: ad7192: Fix ad7193 channel address Mircea Caprioru
2019-02-20 15:35 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).