LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
@ 2019-02-20  2:23 YueHaibing
  2019-02-20  6:31 ` Jarkko Sakkinen
  0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-02-20  2:23 UTC (permalink / raw)
  To: peterhuewe, jarkko.sakkinen, jgg, arnd, gregkh
  Cc: linux-kernel, linux-integrity, linux-security-module, YueHaibing

calc_tpm2_event_size() has an invalid signature because
it returns a 'size_t' where as its signature says that
it returns 'int'.

Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: modify patch title and commit message as Jarkko suggested
---
 drivers/char/tpm/eventlog/tpm2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/eventlog/tpm2.c b/drivers/char/tpm/eventlog/tpm2.c
index d8b7713..f824563 100644
--- a/drivers/char/tpm/eventlog/tpm2.c
+++ b/drivers/char/tpm/eventlog/tpm2.c
@@ -37,8 +37,8 @@
  *
  * Returns size of the event. If it is an invalid event, returns 0.
  */
-static int calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
-				struct tcg_pcr_event *event_header)
+static size_t calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
+				   struct tcg_pcr_event *event_header)
 {
 	struct tcg_efi_specid_event_head *efispecid;
 	struct tcg_event_field *event_field;
-- 
2.7.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
  2019-02-20  2:23 [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size() YueHaibing
@ 2019-02-20  6:31 ` Jarkko Sakkinen
  2019-02-20 16:00   ` Jason Gunthorpe
  0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Sakkinen @ 2019-02-20  6:31 UTC (permalink / raw)
  To: YueHaibing
  Cc: peterhuewe, jgg, arnd, gregkh, linux-kernel, linux-integrity,
	linux-security-module

On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> calc_tpm2_event_size() has an invalid signature because
> it returns a 'size_t' where as its signature says that
> it returns 'int'.
> 
> Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Two remarks:

- git config user.name "Yue Haibing"
- "Cc: stable@vger.kernel.org" before the fixes tag.

Thanks.

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
  2019-02-20  6:31 ` Jarkko Sakkinen
@ 2019-02-20 16:00   ` Jason Gunthorpe
  2019-02-21 12:13     ` Jarkko Sakkinen
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2019-02-20 16:00 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: YueHaibing, peterhuewe, arnd, gregkh, linux-kernel,
	linux-integrity, linux-security-module

On Wed, Feb 20, 2019 at 08:31:59AM +0200, Jarkko Sakkinen wrote:
> On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> > calc_tpm2_event_size() has an invalid signature because
> > it returns a 'size_t' where as its signature says that
> > it returns 'int'.
> > 
> > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
> > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Two remarks:
> 
> - git config user.name "Yue Haibing"
> - "Cc: stable@vger.kernel.org" before the fixes tag.

'Theoretical' bug fixes are not suitable for stable

Jason

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
  2019-02-20 16:00   ` Jason Gunthorpe
@ 2019-02-21 12:13     ` Jarkko Sakkinen
  0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2019-02-21 12:13 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: YueHaibing, peterhuewe, arnd, gregkh, linux-kernel,
	linux-integrity, linux-security-module

On Wed, Feb 20, 2019 at 09:00:42AM -0700, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 08:31:59AM +0200, Jarkko Sakkinen wrote:
> > On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> > > calc_tpm2_event_size() has an invalid signature because
> > > it returns a 'size_t' where as its signature says that
> > > it returns 'int'.
> > > 
> > > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
> > > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > 
> > Two remarks:
> > 
> > - git config user.name "Yue Haibing"
> > - "Cc: stable@vger.kernel.org" before the fixes tag.
> 
> 'Theoretical' bug fixes are not suitable for stable

AFAIK there is no hard rule here. For this one line change I think it
makes sense to backport it even if it is only for avoiding conflicts
with future backports.

/Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-21 12:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20  2:23 [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size() YueHaibing
2019-02-20  6:31 ` Jarkko Sakkinen
2019-02-20 16:00   ` Jason Gunthorpe
2019-02-21 12:13     ` Jarkko Sakkinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).