LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com
Cc: andrey.grodzovsky@amd.com, daniel.vetter@ffwll.ch,
linux-kernel@vger.kernel.org, "Tomasz Figa" <tfiga@chromium.org>,
boris.brezillon@collabora.com, "David Airlie" <airlied@linux.ie>,
"Sean Paul" <seanpaul@google.com>,
kernel@collabora.com, harry.wentland@amd.com,
"Stéphane Marchesin" <marcheu@google.com>,
"Helen Koike" <helen.koike@collabora.com>,
"Sean Paul" <sean@poorly.run>, "Sandy Huang" <hjc@rock-chips.com>,
eric@anholt.net, "Alex Deucher" <alexander.deucher@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>,
amd-gfx@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Rob Clark" <robdclark@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>, "Leo Li" <sunpeng.li@amd.com>,
linux-arm-msm@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org,
"David Francis" <David.Francis@amd.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
freedreno@lists.freedesktop.org,
"Mamta Shukla" <mamtashukla555@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Subject: [PATCH v3 0/5] drm: Fix fb changes for async updates
Date: Wed, 13 Mar 2019 21:20:21 -0300 [thread overview]
Message-ID: <20190314002027.7833-1-helen.koike@collabora.com> (raw)
Hello,
This series fixes the slow down in performance introduced by
"[PATCH v2] drm: Block fb changes for async plane updates" where async update
falls back to a sync update, causing igt failures of type:
"CRITICAL: completed 97 cursor updated in a period of 30 flips, we
expect to complete approximately 15360 updates, with the threshold set
at 7680"
Please read the commit message of "drm: don't block fb changes for async
plane updates" to understand how it works.
I tested on the rockchip, on i915 and on vc4 with igt plane_cursor_legacy and
kms_cursor_legacy and I didn't see any regressions.
I couldn't test on MSM and AMD because I don't have the hardware
I would appreciate if anyone could help me testing those.
v1 link: https://patchwork.kernel.org/cover/10837847/
Thanks!
Helen
Changes in v3:
- use swap() to swap old and new framebuffers in async_update
- get the reference to old_fb and set the worker after vop_plane_atomic_update()
- add a FIXME tag for when we have multiple fbs to be released when
vblank happens.
- update commit message
- Add Reviewed-by tags
- Add TODO in drm_atomic_helper_async_commit()
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen Koike (5):
drm/rockchip: fix fb references in async update
drm/amd: fix fb references in async update
drm/msm: fix fb references in async update
drm/vc4: fix fb references in async update
drm: don't block fb changes for async plane updates
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
drivers/gpu/drm/drm_atomic_helper.c | 22 ++++----
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 51 ++++++++++---------
drivers/gpu/drm/vc4/vc4_plane.c | 2 +-
include/drm/drm_modeset_helper_vtables.h | 5 ++
6 files changed, 49 insertions(+), 38 deletions(-)
--
2.20.1
next reply other threads:[~2019-03-14 0:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 0:20 Helen Koike [this message]
2019-03-14 0:20 ` [PATCH v3 1/5] drm/rockchip: fix fb references in async update Helen Koike
2019-03-14 0:20 ` [PATCH v3 2/5] drm/amd: " Helen Koike
2019-03-14 0:20 ` [PATCH v3 3/5] drm/msm: " Helen Koike
2019-03-27 14:52 ` Rob Clark
2019-04-03 18:03 ` Helen Koike
2019-05-31 17:54 ` Helen Koike
2019-05-31 18:50 ` Rob Clark
2019-03-14 0:20 ` [PATCH v3 4/5] drm/vc4: " Helen Koike
2019-03-14 0:20 ` [PATCH v3 5/5] drm: don't block fb changes for async plane updates Helen Koike
2019-05-07 20:18 ` Sean Paul
2019-06-03 16:53 ` Helen Koike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314002027.7833-1-helen.koike@collabora.com \
--to=helen.koike@collabora.com \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=David.Francis@amd.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrey.grodzovsky@amd.com \
--cc=boris.brezillon@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=freedreno@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mamtashukla555@gmail.com \
--cc=marcheu@google.com \
--cc=maxime.ripard@bootlin.com \
--cc=mikita.lipski@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=seanpaul@google.com \
--cc=sunpeng.li@amd.com \
--cc=tfiga@chromium.org \
--cc=ville.syrjala@linux.intel.com \
--subject='Re: [PATCH v3 0/5] drm: Fix fb changes for async updates' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).