LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: torvalds@linux-foundation.org, akpm@linux-foundation.org
Cc: arnd@arndb.de, linux-arch@vger.kernel.org, mick@ics.forth.gr,
linux-kernel@vger.kernel.org
Subject: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess
Date: Fri, 12 Apr 2019 16:35:38 +0200 [thread overview]
Message-ID: <20190412143538.11780-1-hch@lst.de> (raw)
When removing some dead big endian checks in the RISC-V code Nick
suggested that we should have some generic sanity checks. I don't think
we should have thos inside the RISC-V code, but maybe it might make
sense to have these in the generic byteorder headers. Note that these
are UAPI headers and some compilers might not actually define
__BYTE_ORDER__, so we first check that it actually exists.
Suggested-by: Nick Kossifidis <mick@ics.forth.gr>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
include/uapi/linux/byteorder/big_endian.h | 4 ++++
include/uapi/linux/byteorder/little_endian.h | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/include/uapi/linux/byteorder/big_endian.h b/include/uapi/linux/byteorder/big_endian.h
index 2199adc6a6c2..34a5864526d2 100644
--- a/include/uapi/linux/byteorder/big_endian.h
+++ b/include/uapi/linux/byteorder/big_endian.h
@@ -2,6 +2,10 @@
#ifndef _UAPI_LINUX_BYTEORDER_BIG_ENDIAN_H
#define _UAPI_LINUX_BYTEORDER_BIG_ENDIAN_H
+#if defined(__BYTE_ORDER__) && __BYTE_ORDER__ != __ORDER_BIG_ENDIAN__
+#error "Unsupported endianess, check your toolchain"
+#endif
+
#ifndef __BIG_ENDIAN
#define __BIG_ENDIAN 4321
#endif
diff --git a/include/uapi/linux/byteorder/little_endian.h b/include/uapi/linux/byteorder/little_endian.h
index 601c904fd5cd..0cdf3583e19f 100644
--- a/include/uapi/linux/byteorder/little_endian.h
+++ b/include/uapi/linux/byteorder/little_endian.h
@@ -2,6 +2,10 @@
#ifndef _UAPI_LINUX_BYTEORDER_LITTLE_ENDIAN_H
#define _UAPI_LINUX_BYTEORDER_LITTLE_ENDIAN_H
+#if defined(__BYTE_ORDER__) && __BYTE_ORDER__ != __ORDER_LITTLE_ENDIAN__
+#error "Unsupported endianess, check your toolchain"
+#endif
+
#ifndef __LITTLE_ENDIAN
#define __LITTLE_ENDIAN 1234
#endif
--
2.20.1
next reply other threads:[~2019-04-12 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 14:35 Christoph Hellwig [this message]
2019-04-12 14:53 ` Arnd Bergmann
2019-04-12 14:55 ` Christoph Hellwig
2019-04-12 15:22 ` Arnd Bergmann
2019-04-12 16:05 ` Nick Kossifidis
2019-05-10 10:53 ` Dmitry Vyukov
2019-05-11 0:51 ` Arnd Bergmann
2019-05-13 7:39 ` Dmitry Vyukov
2019-05-13 11:33 ` Michael Ellerman
2019-05-13 11:50 ` Dmitry Vyukov
2019-05-13 12:04 ` Christoph Hellwig
2019-05-15 6:53 ` Arnd Bergmann
2019-05-30 1:46 ` Maciej Rozycki
2019-05-30 6:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412143538.11780-1-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mick@ics.forth.gr \
--cc=torvalds@linux-foundation.org \
--subject='Re: [PATCH, RFC] byteorder: sanity check toolchain vs kernel endianess' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).