LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Yan,
	Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
	Ilya Dryomov <idryomov@gmail.com>,
	ceph-devel@vger.kernel.org
Subject: Re: [PATCH 4/5] ceph: fix improper use of smp_mb__before_atomic()
Date: Tue, 30 Apr 2019 10:23:32 +0200	[thread overview]
Message-ID: <20190430082332.GB2677@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1556568902-12464-5-git-send-email-andrea.parri@amarulasolutions.com>

On Mon, Apr 29, 2019 at 10:15:00PM +0200, Andrea Parri wrote:
> This barrier only applies to the read-modify-write operations; in
> particular, it does not apply to the atomic64_set() primitive.
> 
> Replace the barrier with an smp_mb().
> 

> @@ -541,7 +541,7 @@ static inline void __ceph_dir_set_complete(struct ceph_inode_info *ci,
>  					   long long release_count,
>  					   long long ordered_count)
>  {
> -	smp_mb__before_atomic();

same
	/*
	 * XXX: the comment that explain this barrier goes here.
	 */

> +	smp_mb();

>  	atomic64_set(&ci->i_complete_seq[0], release_count);
>  	atomic64_set(&ci->i_complete_seq[1], ordered_count);
>  }
> -- 
> 2.7.4
> 

  reply	other threads:[~2019-04-30  8:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 20:14 [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic() Andrea Parri
2019-04-29 20:14 ` [PATCH 1/5] drm/msm: " Andrea Parri
2019-05-09 20:19   ` Andrea Parri
2019-04-29 20:14 ` [PATCH 2/5] bio: fix improper use of smp_mb__before_atomic() Andrea Parri
2019-04-30  8:21   ` Peter Zijlstra
2019-05-09 20:23   ` Andrea Parri
2019-05-10  3:40   ` Ming Lei
2019-04-29 20:14 ` [PATCH 3/5] sbitmap: " Andrea Parri
2019-05-09 20:26   ` Andrea Parri
2019-05-10  3:41   ` Ming Lei
2019-05-10  6:27     ` Andrea Parri
2019-04-29 20:15 ` [PATCH 4/5] ceph: " Andrea Parri
2019-04-30  8:23   ` Peter Zijlstra [this message]
2019-04-30  9:08     ` Yan, Zheng
2019-05-09 20:55       ` Andrea Parri
2019-05-13 13:04         ` Yan, Zheng
2019-05-13 22:47           ` Andrea Parri
2019-04-29 20:15 ` [PATCH 5/5] IB/hfi1: Fix improper uses " Andrea Parri
2019-04-29 21:24   ` Ruhl, Michael J
2019-04-29 23:16     ` Andrea Parri
2019-05-09 21:12       ` Andrea Parri
2019-05-14 12:32         ` Dennis Dalessandro
2019-05-14 14:48           ` Andrea Parri
2019-04-30  8:28   ` Peter Zijlstra
2019-04-30  8:34 ` [PATCH 0/5] Fix improper uses of smp_mb__{before,after}_atomic() Peter Zijlstra
2019-04-30 16:44   ` Andrea Parri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190430082332.GB2677@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andrea.parri@amarulasolutions.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sage@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=zyan@redhat.com \
    --subject='Re: [PATCH 4/5] ceph: fix improper use of smp_mb__before_atomic()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).