LKML Archive on
help / color / mirror / Atom feed
From: Kalle Valo <>
To: "Gustavo A. R. Silva" <>
Cc: "David S. Miller" <>,,,,,
	"Gustavo A. R. Silva" <>
Subject: Re: [PATCH][next] ath10k: coredump: use struct_size() helper
Date: Tue,  7 May 2019 13:53:14 +0000 (UTC)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190403190636.GA9827@embeddedor>

"Gustavo A. R. Silva" <> wrote:

> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
> So, replace code of the following form:
> sizeof(*ce_hdr) + CE_COUNT * sizeof(ce_hdr->entries[0])
> with:
> struct_size(ce_hdr, entries, CE_COUNT)
> This code was detected with the help of Coccinelle.
> Signed-off-by: Gustavo A. R. Silva <>
> Signed-off-by: Kalle Valo <>

Patch applied to ath-next branch of ath.git, thanks.

4f735cd73650 ath10k: coredump: use struct_size() helper


      reply	other threads:[~2019-05-07 13:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 19:06 Gustavo A. R. Silva
2019-05-07 13:53 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][next] ath10k: coredump: use struct_size() helper' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).