LKML Archive on
help / color / mirror / Atom feed
From: Borislav Petkov <>
To: Linus Torvalds <>
Cc: Rik van Riel <>,
	Sebastian Andrzej Siewior <>,
	x86-ml <>, lkml <>
Subject: Re: [GIT PULL] x86 FPU changes for 5.2
Date: Tue, 7 May 2019 19:59:13 +0200	[thread overview]
Message-ID: <20190507175913.GC26655@zn.tnic> (raw)
In-Reply-To: <>

On Tue, May 07, 2019 at 10:35:25AM -0700, Linus Torvalds wrote:
> I love this and we should have done it long ago, but I also worry that
> every time we've messed with the FP state, we've had interesting bugs.

Tell me about it. Our FPU code is one helluva contraption.

> Which is obviously why we didn't do this long ago.
> Has this gone through lots of testing, particularly with things like
> FP signal handling and old machines that don't necessarily have
> anything but the most basic FP state (ie Pentium class etc)?

Right, so I ran it on the bunch of boxes I have here, the oldest is a K8
which has:

[    0.000000] x86/fpu: x87 FPU will use FXSAVE

and it looked ok. Ingo ran it on his fleet too, AFAIR.

Lemme see if I can dig out something older at work.

> I've pulled it, but I'd still like to feel safer about it after-the-fact ;)



SUSE Linux GmbH, GF: Felix Imendörffer, Mary Higgins, Sri Rasiah, HRB 21284 (AG Nürnberg)

  reply	other threads:[~2019-05-07 17:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:26 Borislav Petkov
2019-05-07 17:35 ` Linus Torvalds
2019-05-07 17:59   ` Borislav Petkov [this message]
2019-05-07 20:12   ` Ingo Molnar
2019-05-07 21:59   ` Sebastian Andrzej Siewior
2019-05-07 17:55 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190507175913.GC26655@zn.tnic \ \ \ \ \ \ \
    --subject='Re: [GIT PULL] x86 FPU changes for 5.2' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).