LKML Archive on
help / color / mirror / Atom feed
From: Ingo Molnar <>
To: Linus Torvalds <>
Cc: Borislav Petkov <>, Rik van Riel <>,
	Sebastian Andrzej Siewior <>,
	x86-ml <>, lkml <>
Subject: Re: [GIT PULL] x86 FPU changes for 5.2
Date: Tue, 7 May 2019 22:12:28 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

* Linus Torvalds <> wrote:

> On Tue, May 7, 2019 at 6:26 AM Borislav Petkov <> wrote:
> >
> > This branch contains work started by Rik van Riel and brought to 
> > fruition by Sebastian Andrzej Siewior with the main goal to optimize 
> > when to load FPU registers: only when returning to userspace and not 
> > on every context switch (while the task remains in the kernel).
> I love this and we should have done it long ago, but I also worry that 
> every time we've messed with the FP state, we've had interesting bugs. 
> Which is obviously why we didn't do this long ago.
> Has this gone through lots of testing, particularly with things like FP 
> signal handling and old machines that don't necessarily have anything 
> but the most basic FP state (ie Pentium class etc)?
> I've pulled it, but I'd still like to feel safer about it 
> after-the-fact ;)

Most of the x86/fpu commits except the final one are several weeks old, 
but I have to admit that our old-systems testing is hit and miss, and FPU 
bugs do tend to have an additional 'bug report latency' multipier of a 
factor of 3 or so ...

I've been running all this (modulo the final commit) on my primary 
desktop and other systems as well, FWIIW.



  parent reply	other threads:[~2019-05-07 20:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:26 Borislav Petkov
2019-05-07 17:35 ` Linus Torvalds
2019-05-07 17:59   ` Borislav Petkov
2019-05-07 20:12   ` Ingo Molnar [this message]
2019-05-07 21:59   ` Sebastian Andrzej Siewior
2019-05-07 17:55 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [GIT PULL] x86 FPU changes for 5.2' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).