LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] net: dsa: sja1105: Make 'sja1105et_regs' and 'sja1105pqrs_regs' static
@ 2019-05-08 13:43 Wang Hai
  2019-05-08 16:46 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2019-05-08 13:43 UTC (permalink / raw)
  To: olteanv, andrew, vivien.didelot, f.fainelli, davem
  Cc: linux-kernel, netdev, wanghai26

drivers/net/dsa/sja1105/sja1105_spi.c:486:21: warning: symbol 'sja1105et_regs' was not declared. Should it be static?
drivers/net/dsa/sja1105/sja1105_spi.c:511:21: warning: symbol 'sja1105pqrs_regs' was not declared. Should it be static?

Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai26@huawei.com>
---
 drivers/net/dsa/sja1105/sja1105_spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_spi.c b/drivers/net/dsa/sja1105/sja1105_spi.c
index 244a94ccfc18..6848d82e423a 100644
--- a/drivers/net/dsa/sja1105/sja1105_spi.c
+++ b/drivers/net/dsa/sja1105/sja1105_spi.c
@@ -483,7 +483,7 @@ int sja1105_static_config_upload(struct sja1105_private *priv)
 	return rc;
 }
 
-struct sja1105_regs sja1105et_regs = {
+static struct sja1105_regs sja1105et_regs = {
 	.device_id = 0x0,
 	.prod_id = 0x100BC3,
 	.status = 0x1,
@@ -508,7 +508,7 @@ struct sja1105_regs sja1105et_regs = {
 	.rmii_ext_tx_clk = {0x100018, 0x10001F, 0x100026, 0x10002D, 0x100034},
 };
 
-struct sja1105_regs sja1105pqrs_regs = {
+static struct sja1105_regs sja1105pqrs_regs = {
 	.device_id = 0x0,
 	.prod_id = 0x100BC3,
 	.status = 0x1,
-- 
2.17.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: dsa: sja1105: Make 'sja1105et_regs' and 'sja1105pqrs_regs' static
  2019-05-08 13:43 [PATCH] net: dsa: sja1105: Make 'sja1105et_regs' and 'sja1105pqrs_regs' static Wang Hai
@ 2019-05-08 16:46 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-05-08 16:46 UTC (permalink / raw)
  To: wanghai26
  Cc: olteanv, andrew, vivien.didelot, f.fainelli, linux-kernel, netdev

From: Wang Hai <wanghai26@huawei.com>
Date: Wed, 8 May 2019 21:43:26 +0800

> drivers/net/dsa/sja1105/sja1105_spi.c:486:21: warning: symbol 'sja1105et_regs' was not declared. Should it be static?
> drivers/net/dsa/sja1105/sja1105_spi.c:511:21: warning: symbol 'sja1105pqrs_regs' was not declared. Should it be static?
> 
> Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai26@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-08 16:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 13:43 [PATCH] net: dsa: sja1105: Make 'sja1105et_regs' and 'sja1105pqrs_regs' static Wang Hai
2019-05-08 16:46 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).