LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h
@ 2019-04-13 15:15 Paul Gortmaker
  2019-05-08  9:01 ` Applied "sound: soc-acpi: fix implicit header use of module.h/export.h" to the asoc tree Mark Brown
  2019-05-08  9:07 ` [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Paul Gortmaker @ 2019-04-13 15:15 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paul Gortmaker, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai

This file is implicitly relying on an instance of including
module.h from <linux/acpi.h>.

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Here, we make the include explicit, in order to allow the future
removal of module.h from linux/acpi.h without causing build breakage.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 4fb29f0e561e..444ce0602f76 100644
--- a/sound/soc/soc-acpi.c
+++ b/sound/soc/soc-acpi.c
@@ -4,6 +4,8 @@
 //
 // Copyright (c) 2013-15, Intel Corporation.
 
+#include <linux/export.h>
+#include <linux/module.h>
 #include <sound/soc-acpi.h>
 
 struct snd_soc_acpi_mach *
-- 
2.11.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "sound: soc-acpi: fix implicit header use of module.h/export.h" to the asoc tree
  2019-04-13 15:15 [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h Paul Gortmaker
@ 2019-05-08  9:01 ` Mark Brown
  2019-05-08  9:07 ` [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-05-08  9:01 UTC (permalink / raw)
  To: Paul Gortmaker
  Cc: alsa-devel, Jaroslav Kysela, Liam Girdwood, linux-kernel,
	Mark Brown, Takashi Iwai

The patch

   sound: soc-acpi: fix implicit header use of module.h/export.h

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 473849e7f208b2d7de004c6c6c0eabe037d125ac Mon Sep 17 00:00:00 2001
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Sat, 13 Apr 2019 11:15:18 -0400
Subject: [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h

This file is implicitly relying on an instance of including
module.h from <linux/acpi.h>.

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Here, we make the include explicit, in order to allow the future
removal of module.h from linux/acpi.h without causing build breakage.

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/soc-acpi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 4fb29f0e561e..444ce0602f76 100644
--- a/sound/soc/soc-acpi.c
+++ b/sound/soc/soc-acpi.c
@@ -4,6 +4,8 @@
 //
 // Copyright (c) 2013-15, Intel Corporation.
 
+#include <linux/export.h>
+#include <linux/module.h>
 #include <sound/soc-acpi.h>
 
 struct snd_soc_acpi_mach *
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h
  2019-04-13 15:15 [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h Paul Gortmaker
  2019-05-08  9:01 ` Applied "sound: soc-acpi: fix implicit header use of module.h/export.h" to the asoc tree Mark Brown
@ 2019-05-08  9:07 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-05-08  9:07 UTC (permalink / raw)
  To: Paul Gortmaker; +Cc: linux-kernel, Liam Girdwood, Jaroslav Kysela, Takashi Iwai

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

On Sat, Apr 13, 2019 at 11:15:18AM -0400, Paul Gortmaker wrote:
> This file is implicitly relying on an instance of including
> module.h from <linux/acpi.h>.

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-08  9:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-13 15:15 [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h Paul Gortmaker
2019-05-08  9:01 ` Applied "sound: soc-acpi: fix implicit header use of module.h/export.h" to the asoc tree Mark Brown
2019-05-08  9:07 ` [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).