LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] EDAC, mpc85xx: Prevent building as a module
@ 2019-05-02 14:19 Michael Ellerman
  2019-05-06  6:50 ` Johannes Thumshirn
  0 siblings, 1 reply; 11+ messages in thread
From: Michael Ellerman @ 2019-05-02 14:19 UTC (permalink / raw)
  To: linux-edac
  Cc: morbidrsa, bp, mchehab, james.morse, linux-kernel, linuxppc-dev

The mpc85xx EDAC code can be configured as a module but then fails to
build because it uses two unexported symbols:

  ERROR: ".pci_find_hose_for_OF_device" [drivers/edac/mpc85xx_edac_mod.ko] undefined!
  ERROR: ".early_find_capability" [drivers/edac/mpc85xx_edac_mod.ko] undefined!

We don't want to export those symbols just for this driver, so make
the driver only configurable as a built-in.

This seems to have been broken since at least commit c92132f59806
("edac/85xx: Add PCIe error interrupt edac support") (Nov 2013).

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 drivers/edac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 47eb4d13ed5f..6317519f9d88 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -263,7 +263,7 @@ config EDAC_PND2
 	  micro-server but may appear on others in the future.
 
 config EDAC_MPC85XX
-	tristate "Freescale MPC83xx / MPC85xx"
+	bool "Freescale MPC83xx / MPC85xx"
 	depends on FSL_SOC
 	help
 	  Support for error detection and correction on the Freescale
-- 
2.20.1


^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-05-14  8:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-02 14:19 [PATCH] EDAC, mpc85xx: Prevent building as a module Michael Ellerman
2019-05-06  6:50 ` Johannes Thumshirn
2019-05-08 10:12   ` Borislav Petkov
2019-05-09 14:52     ` Michael Ellerman
2019-05-09 14:55       ` Borislav Petkov
2019-05-09 18:02         ` Borislav Petkov
2019-05-10 10:50           ` Michael Ellerman
2019-05-10 14:13             ` Borislav Petkov
2019-05-10 18:25               ` Borislav Petkov
2019-05-14  6:50                 ` Michael Ellerman
2019-05-14  8:31                   ` Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).